fix(installer): preserve npm lockfiles during install #4029
+116
−21
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| // SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import { readFileSync } from "node:fs"; | ||
| import { join } from "node:path"; | ||
| import { describe, expect, it } from "vitest"; | ||
| import YAML from "yaml"; | ||
|
|
||
| const REPO_ROOT = join(import.meta.dirname, ".."); | ||
|
|
||
| type CompositeAction = { | ||
| runs?: { | ||
| steps?: Array<{ | ||
| name?: string; | ||
| run?: string; | ||
| }>; | ||
| }; | ||
| }; | ||
|
|
||
| function loadBasicChecksAction(): CompositeAction { | ||
| return YAML.parse( | ||
| readFileSync(join(REPO_ROOT, ".github/actions/basic-checks/action.yaml"), "utf-8"), | ||
| ) as CompositeAction; | ||
| } | ||
|
|
||
| describe("lockfile CI guards", () => { | ||
| it("validates root and sandbox payload lockfiles before install can rewrite them", () => { | ||
| const action = loadBasicChecksAction(); | ||
| const steps = action.runs?.steps ?? []; | ||
| const validateIndex = steps.findIndex((step) => step.name === "Validate npm lockfiles"); | ||
| const installIndex = steps.findIndex((step) => step.name === "Install dependencies"); | ||
| const validateStep = steps[validateIndex]; | ||
|
|
||
| expect(validateIndex).toBeGreaterThanOrEqual(0); | ||
| expect(installIndex).toBeGreaterThanOrEqual(0); | ||
| expect(validateIndex).toBeLessThan(installIndex); | ||
| expect(validateStep?.run?.trimEnd()).toBe( | ||
| [ | ||
| "npm ci --ignore-scripts --dry-run", | ||
| "cd nemoclaw", | ||
| "npm ci --ignore-scripts --dry-run", | ||
| ].join("\n"), | ||
| ); | ||
| }); | ||
|
|
||
| it("uses npm ci for root and sandbox payload installs in basic checks", () => { | ||
| const action = loadBasicChecksAction(); | ||
| const installStep = action.runs?.steps?.find((step) => step.name === "Install dependencies"); | ||
|
|
||
| expect(installStep?.run?.trimEnd()).toBe( | ||
| ["npm ci --ignore-scripts", "cd nemoclaw", "npm ci --ignore-scripts"].join("\n"), | ||
| ); | ||
| expect(installStep?.run).not.toContain("npm install"); | ||
| }); | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
writeNpmStub()still leaves many test-specific handlers rejectingnpm ci.Line 98 now dispatches
ci, but a lot of callers in this file still only branch on"$1" = "install"insideinstallSnippet. Those tests will now fall through tounexpected npm invocation: ci --ignore-scripts, so the suite is still out of sync with the installer change.🤖 Prompt for AI Agents