fix: address issue #5211#5213
Closed
jason-ma-nv wants to merge 1 commit into
Closed
Conversation
The "NemoClaw for Hermes Agent" API Catalog Try Now flow reuses the OpenClaw Brev launchable, which leaves NEMOCLAW_AGENT unset. NemoClaw then defaults the agent to openclaw (resolveAgentName / install.sh), so the Launch page reports RUNTIME=OpenClaw even though Hermes was selected (#5211). Add a warning and a "Deploy Hermes Instead of OpenClaw" section to the Brev web UI guide explaining that the launchable must export NEMOCLAW_AGENT=hermes to provision the Hermes runtime, and that omitting it silently falls back to OpenClaw. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
📝 WalkthroughWalkthroughDocumentation enhancement for the Brev web UI deployment process. Added a warning block clarifying OpenClaw as the default runtime and explaining the ChangesRuntime Selection Documentation
🎯 2 (Simple) | ⏱️ ~8 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
🌿 Preview your docs: https://nvidia-preview-pr-5213.docs.buildwithfern.com/nemoclaw |
Contributor
E2E Advisor RecommendationRequired E2E: None Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
|
Contributor
Vitest E2E Scenario RecommendationRequired Vitest E2E scenarios: None Full Vitest E2E advisor summaryVitest E2E Scenario AdvisorBase: Required Vitest E2E scenarios
Optional Vitest E2E scenarios
Relevant changed files
|
Contributor
PR Review AdvisorFindings: 1 needs attention, 1 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Consider writing more tests for
This is an automated advisory review. A human maintainer must make the final merge decision. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/deployment/brev-web-ui.mdx (1)
40-40: ⚡ Quick winUse active voice.
"The deployed agent is selected from" is passive. Rewrite to active voice.
Suggested revision:
-The deployed agent is selected from the `NEMOCLAW_AGENT` environment variable that the launchable passes to the installer: +The launchable selects the deployed agent from the `NEMOCLAW_AGENT` environment variable that it passes to the installer:🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/deployment/brev-web-ui.mdx` at line 40, Rewrite the passive sentence to active voice by making the subject the launchable: e.g., say that the launchable selects the deployed agent from the NEMOCLAW_AGENT environment variable and passes it to the installer; reference the environment variable name NEMOCLAW_AGENT and the actors "launchable" and "installer" (replace the existing passive sentence with this active construction).Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/deployment/brev-web-ui.mdx`:
- Line 40: Rewrite the passive sentence to active voice by making the subject
the launchable: e.g., say that the launchable selects the deployed agent from
the NEMOCLAW_AGENT environment variable and passes it to the installer;
reference the environment variable name NEMOCLAW_AGENT and the actors
"launchable" and "installer" (replace the existing passive sentence with this
active construction).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: b02dc667-915c-44c0-972e-9cb00c523189
📒 Files selected for processing (1)
docs/deployment/brev-web-ui.mdx
Contributor
Author
|
Closing this PR. After analysis, the root cause of #5211 is platform-side: the NemoClaw for Hermes Agent API Catalog Try Now flow reuses the OpenClaw Brev launchable ( A docs-only change cannot make the Try-Now button deploy Hermes, so this does not actually fix #5211. The real fix is a launchable update on the Brev/build.nvidia.com side (see issue comment). A separate PR will add a defensive in-repo guard that surfaces the silent OpenClaw fallback at deploy time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Issue #5211: the 'NemoClaw for Hermes Agent' API Catalog Try Now flow deploys the OpenClaw runtime instead of Hermes. Root cause: the Hermes catalog card reuses the same Brev launchable (env-3Azt0aYgVNFEuz7opyx3gscmowS) that the repo documents as the OpenClaw web-UI launchable. NemoClaw selects the agent from the NEMOCLAW_AGENT env var (src/lib/agent/defs.ts resolveAgentName; scripts/install.sh:809), which defaults to 'openclaw' when unset, so a launchable that does not export NEMOCLAW_AGENT=hermes silently provisions OpenClaw and the Launch page reports RUNTIME=OpenClaw. The launchable definition itself lives on the Brev/build.nvidia.com platform (outside this repo); the repo's lever is its canonical Brev web-UI documentation, which previously described only the OpenClaw flow and gave no Hermes path. Fix: updated docs/deployment/brev-web-ui.mdx with a Warning callout and a new 'Deploy Hermes Instead of OpenClaw' section documenting that the launchable must export NEMOCLAW_AGENT=hermes to provision Hermes (RUNTIME=Hermes), and that without it the agent silently falls back to OpenClaw.
Related Issue
Fixes #5211
Changes
auto_fix/auto_fix_recent_issues.py.Type of Change
Verification
npx prek run --all-filespassesnpm testpassesmake docsbuilds without warnings (doc changes only)Verification details reported by Claude Code:
grep -rn 'NEMOCLAW_AGENT' scripts/install.shgrep -rn 'launchableID' (docs/mdx/skills)npm run docs:check-agent-variantsgit status --porcelainSigned-off-by: Jason Ma jama@nvidia.com
Summary by CodeRabbit