Skip to content

fix(ci): use existing snap gateway wrapper#1859

Merged
elezar merged 1 commit into
mainfrom
fix/snap-download-artifact-pin
Jun 10, 2026
Merged

fix(ci): use existing snap gateway wrapper#1859
elezar merged 1 commit into
mainfrom
fix/snap-download-artifact-pin

Conversation

@elezar

@elezar elezar commented Jun 10, 2026

Copy link
Copy Markdown
Member

Summary

Fix the snap packaging workflow after the artifact action pin fix in #1855. The snap job now resolves actions/download-artifact, but fails while preparing snap/prebuilt/ because it copies a gateway wrapper from the deleted deploy/snap/ tree.

Related Issue

None.

Changes

  • Copies tasks/scripts/snap-gateway-wrapper.sh into snap/prebuilt/openshell-gateway-wrapper, which is the filename expected by snapcraft.yaml.

Testing

  • git diff --check passes
  • bash -n tasks/scripts/snap-gateway-wrapper.sh passes
  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

@elezar elezar requested review from a team, derekwaynecarr and mrunalp as code owners June 10, 2026 19:52
@elezar elezar enabled auto-merge (squash) June 10, 2026 19:52
pimlock
pimlock previously approved these changes Jun 10, 2026
@elezar

elezar commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

Seems like a duplicate of #1855

@elezar elezar closed this Jun 10, 2026
auto-merge was automatically disabled June 10, 2026 19:56

Pull request was closed

@elezar elezar changed the title fix(ci): correct snap artifact action pin fix(ci): use existing snap gateway wrapper Jun 10, 2026
@elezar elezar reopened this Jun 10, 2026
Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar force-pushed the fix/snap-download-artifact-pin branch from 53c0c44 to 0d7e8f6 Compare June 10, 2026 20:04
@elezar

elezar commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

gator-agent

PR Review Status

Validation: this is maintainer-authored, project-valid CI packaging work. It is related to #1855 but not a duplicate: #1855 fixed the actions/download-artifact pin, while this PR fixes the now-stale snap gateway wrapper copy path reached after that workflow proceeds.
Head SHA: 0d7e8f64cfe8184c441cb9df222dfb792fe290ab

Review findings:

  • No blocking findings remain. The independent review confirmed snapcraft.yaml expects snap/prebuilt/openshell-gateway-wrapper, and the repository contains tasks/scripts/snap-gateway-wrapper.sh.

Docs: not needed; this is CI packaging workflow repair and does not change user-facing Fern docs behavior.
Checks: OpenShell / Branch Checks is still pending; OpenShell / Helm Lint, DCO, docs preview, and non-applied E2E gates are already green or skipped as expected.
E2E: N/A; no test:* label is needed for this one-line snap workflow repair.

Next state: gator:watch-pipeline

@elezar elezar added the gator:watch-pipeline Gator is monitoring PR CI/CD status label Jun 10, 2026
@elezar elezar enabled auto-merge (squash) June 10, 2026 20:10
@elezar elezar merged commit 4a7f8e7 into main Jun 10, 2026
29 checks passed
@elezar elezar deleted the fix/snap-download-artifact-pin branch June 10, 2026 20:14
@elezar

elezar commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

gator-agent

Monitoring Complete

Monitoring is complete because this PR has merged.

Final status: the PR had been under gator:watch-pipeline; it has since merged, so there is nothing left for gator to monitor.

I removed the active gator:* label because there is nothing left for gator to monitor on this PR.

@elezar elezar removed the gator:watch-pipeline Gator is monitoring PR CI/CD status label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants