fix(drivers): filter bind-backed named volumes#1861
Conversation
Signed-off-by: Evan Lezar <elezar@nvidia.com>
|
cc @drew for explicit visibility on this follow-up Podman bind-backed volume filtering PR. |
|
🌿 Preview your docs: https://nvidia-preview-pr-1861.docs.buildwithfern.com/openshell |
PR Review StatusValidation: this is maintainer-authored, project-valid Podman driver security/behavior work. It is a small focused follow-up to make Podman local-driver bind-backed named volumes require the same unsafe operator opt-in as direct bind mounts and Docker bind-backed volumes. Review findings:
Docs: Fern reference docs were updated in existing pages; no navigation change appears needed. Next state: |
|
Label |
Does Docker also support |
Re-check After Author UpdateI re-evaluated latest head Disposition: needs follow-up. Remaining items:
Next state: |
Signed-off-by: Evan Lezar <elezar@nvidia.com>
|
Addressed Gator’s |
Re-check After Author UpdateI re-evaluated latest head Disposition: resolved. Remaining items:
Validation: maintainer-authored Podman/Docker driver security behavior follow-up for bind-backed named volumes. Next state: Human maintainer approval or merge decision is now required. |
Monitoring CompleteMonitoring is complete because this PR has merged. Final status: latest gator state was I removed the active |
Summary
Add Podman named-volume inspection so OpenShell can detect local-driver volumes created with host bind options. Podman now rejects bind-backed named volumes unless
[openshell.drivers.podman].enable_bind_mounts = true, matching the Docker driver behavior added with the initial driver-config volume mount support.This PR also tightens both Docker and Podman bind-backed volume detection so comma-separated local-driver
o=...options containing eitherbindorrbindare treated as host bind mounts.Related Issue
Follow-up to #1785.
Changes
DriverandOptions.bindandrbindmount options.rw,rbindlocal-driver volume options.Testing
mise run pre-commitpassesChecklist