fix(gateway): gate unsafe auth deployment modes#1871
Open
alangou wants to merge 1 commit into
Open
Conversation
Require explicit opt-in for OIDC authentication-only mode on shared gateway deployments and fail closed when gRPC user requests have no auth path. Align Helm validation, tests, and docs so weak auth modes are intentional and visible. Signed-off-by: Adrien Langou <alangou@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gate unsafe gateway authentication postures for shared deployments. OIDC authentication-only mode now requires an explicit opt-in, and gRPC user requests without an auth path fail closed instead of passing through.
Related Issue
Closes OS-186
Changes
allow_oidc_auth_onlyconfig and Helm value for OIDC authentication-only mode.UNAUTHENTICATED.Testing
mise run pre-commitpassesAdditional validation run:
CARGO_TARGET_DIR="/home/op/OpenShell/target" mise run testCARGO_TARGET_DIR="/home/op/OpenShell/target" mise exec -- cargo test -p openshell-servermise run helm:testmise run helm:lintmise run helm:docs:checkgit diff --checkNote:
mise run pre-commitcould not be confirmed because the shell executor stopped returning statuses.Checklist