Skip to content

fix(gateway): gate unsafe auth deployment modes#1871

Open
alangou wants to merge 1 commit into
NVIDIA:mainfrom
alangou:alangou/os-186-tava-2026-05-fsr-01fsr-15-gate-oidc-auth-only-and-no-auth
Open

fix(gateway): gate unsafe auth deployment modes#1871
alangou wants to merge 1 commit into
NVIDIA:mainfrom
alangou:alangou/os-186-tava-2026-05-fsr-01fsr-15-gate-oidc-auth-only-and-no-auth

Conversation

@alangou

@alangou alangou commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Gate unsafe gateway authentication postures for shared deployments. OIDC authentication-only mode now requires an explicit opt-in, and gRPC user requests without an auth path fail closed instead of passing through.

Related Issue

Closes OS-186

Changes

  • Added gateway auth posture validation for shared Kubernetes/non-loopback deployments.
  • Added explicit allow_oidc_auth_only config and Helm value for OIDC authentication-only mode.
  • Replaced implicit no-auth gRPC pass-through with UNAUTHENTICATED.
  • Updated Helm validation/rendering so auth-only OIDC renders empty roles only when explicitly opted in.
  • Added Rust and Helm tests for auth-only, partial-role rejection, no-auth fail-closed behavior, and explicit dev/proxy no-auth.
  • Updated Kubernetes, reference, security, Helm, and architecture docs.

Testing

  • mise run pre-commit passes
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Additional validation run:

  • CARGO_TARGET_DIR="/home/op/OpenShell/target" mise run test
  • CARGO_TARGET_DIR="/home/op/OpenShell/target" mise exec -- cargo test -p openshell-server
  • mise run helm:test
  • mise run helm:lint
  • mise run helm:docs:check
  • git diff --check

Note: mise run pre-commit could not be confirmed because the shell executor stopped returning statuses.

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)
  • Architecture docs updated (if applicable)

Require explicit opt-in for OIDC authentication-only mode on shared gateway deployments and fail closed when gRPC user requests have no auth path. Align Helm validation, tests, and docs so weak auth modes are intentional and visible.

Signed-off-by: Adrien Langou <alangou@nvidia.com>
@alangou alangou requested review from a team, derekwaynecarr and mrunalp as code owners June 11, 2026 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant