Skip to content

fix(server): use public tonic body type in gRPC rate limiter #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alangou merged 1 commit into from
Jun 11, 2026
+5 −5
Merged

fix(server): use public tonic body type in gRPC rate limiter #1872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions crates/openshell-server/src/multiplex.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ impl<S> GrpcRateLimitService<S> {

impl<S, B> tower::Service<Request<B>> for GrpcRateLimitService<S>
where
S: tower::Service<Request<B>, Response = Response<tonic::body::BoxBody>>,
S: tower::Service<Request<B>, Response = Response<tonic::body::Body>>,
S::Future: Send + 'static,
B: Send + 'static,
{
Expand Down Expand Up @@ -953,7 +953,7 @@ mod tests {
}

impl Service<Request<()>> for CountingGrpcService {
type Response = Response<tonic::body::BoxBody>;
type Response = Response<tonic::body::Body>;
type Error = std::convert::Infallible;
type Future = std::future::Ready<Result<Self::Response, Self::Error>>;

Expand All @@ -963,7 +963,7 @@ mod tests {

fn call(&mut self, _req: Request<()>) -> Self::Future {
self.calls.fetch_add(1, Ordering::Relaxed);
std::future::ready(Ok(Response::new(tonic::body::empty_body())))
std::future::ready(Ok(Response::new(tonic::body::Body::empty())))
}
}

Expand All @@ -985,7 +985,7 @@ mod tests {
}

impl Service<Request<()>> for PendingInnerService {
type Response = Response<tonic::body::BoxBody>;
type Response = Response<tonic::body::Body>;
type Error = std::convert::Infallible;
type Future = std::future::Ready<Result<Self::Response, Self::Error>>;

Expand All @@ -995,7 +995,7 @@ mod tests {

fn call(&mut self, _req: Request<()>) -> Self::Future {
self.calls.fetch_add(1, Ordering::Relaxed);
std::future::ready(Ok(Response::new(tonic::body::empty_body())))
std::future::ready(Ok(Response::new(tonic::body::Body::empty())))
}
}

Expand Down
Loading