fix(docker): add Podman-machine gateway regression test#1873
Closed
Oxygen56 wants to merge 1 commit into
Closed
Conversation
Add a macOS-only regression test for Podman machine bridging (NVIDIA#1358). On macOS hosts the bridge gateway IP only exists inside the VM, so binding fails with EADDRNOTAVAIL. The existing host_runtime_requires_host_gateway_alias() gate already handles this, but the regression test ensures Podman-machine-style SystemInfo (fedora, localhost.localdomain, no labels) is routed via HostGateway. Also document host_runtime_requires_host_gateway_alias() to make the macOS constraint discoverable at the call site. Co-developed-by: Akram Ben Aissi <akram@NVIDIA#1653> Closes NVIDIA#1358 Signed-off-by: Oxygen <1391083091@qq.com>
Oxygen56
requested review from
a team,
derekwaynecarr and
mrunalp
as code owners
|
Thank you for your interest in contributing to OpenShell, @Oxygen56. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
|
Thank you for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. You can retrigger this bot by commenting recheck in this Pull Request. Posted by the DCO Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a macOS-only regression test for Podman machine bridging (#1358), picking up where #1653 left off per @drew's review.
What happened in #1653
#1653 added both a regression test and a redundant macOS early-return in
uses_host_gateway_alias(). However, #1516 had already extracted the macOS logic intohost_runtime_requires_host_gateway_alias(), making theuses_host_gateway_alias()change unnecessary.What this PR does
host_runtime_requires_host_gateway_alias()to explain why macOS always routes via host-gatewaydocker_gateway_route_uses_host_gateway_for_podman_machine_on_macos), gated on#[cfg(target_os = "macos")], which reproduces the exact failure from bug: gateway crash-loops on macOS — binds to VM-internal podman bridge IP (10.89.0.1) on host #1358: a Podman machine daemon reportingfedora/localhost.localdomain/ no labels routes callbacks viaHostGatewayinstead ofBridgeNo changes to
uses_host_gateway_alias()— the routing behavior is unchanged.Related
cc @akram @drew @johntmyers