feat(plugin): Add Plugin evaluation support across all tiers - #28
Open
chrisknvidia wants to merge 20 commits into
Open
feat(plugin): Add Plugin evaluation support across all tiers#28chrisknvidia wants to merge 20 commits into
chrisknvidia wants to merge 20 commits into
Conversation
Restores and rebases the plugin evaluation work from PR #17 onto the rewritten main history. Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
rng1995
force-pushed
the
naren/plugin-evaluation-all-tiers
branch
from
August 4, 2026 19:14
3a51f76 to
a4a5e63
Compare
Use boundary-aware checks for reserved names, description heuristics, API and error documentation, MCP guidance, time references, README mentions, and nested Markdown links. Add regression coverage for #30. Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
rng1995
reviewed
Aug 5, 2026
rng1995
left a comment
rng1995
left a comment
Collaborator
There was a problem hiding this comment.
The plugin evaluation implementation and its follow-up hardening are well covered, but I found one small diff-hygiene issue to clean up.
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
rng1995
reviewed
Aug 12, 2026
rng1995
left a comment
rng1995
left a comment
Collaborator
There was a problem hiding this comment.
Fresh review found two actionable security issues in the plugin evaluation staging path. The previous EOF-hygiene thread is already fixed and resolved. I will address these findings while updating the branch from current main.
…on-all-tiers Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com> # Conflicts: # docs/tier2-deduplication.mdx # src/skillevaluator/deduplication/utils/skill_collector.py # src/skillevaluator/embedding/extractor.py
…on-all-tiers Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
…on-all-tiers Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com> # Conflicts: # .github/workflows/ci.yml # CHANGELOG.md # src/skillevaluator/tier3/harbor/adapter.py # src/skillevaluator/tier3/harbor/runner.py # src/skillevaluator/utils/secure_fs.py # tests/test_harbor_input_staging.py
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
rng1995
approved these changes
Aug 12, 2026
rng1995
left a comment
rng1995
left a comment
Collaborator
There was a problem hiding this comment.
Approved after fresh security review and remediation: all review threads are resolved, the branch is conflict-free against current main, the complete local suite passes (3,999 passed, 21 skipped, 3 deselected), and all 15 GitHub checks pass including Windows, packaging, DCO, and security scans.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoration note
This PR replaces #17, which GitHub permanently closed after the default-branch history was consolidated and the original head branch was deleted and recreated. The original discussion and commit history remain available on #17.
This replacement contains the intended plugin-evaluation change set rebased onto the current
mainas one Narendran commit. The olderresult_display.pydelta was not reapplied because currentmainalready contains the newer, stronger hardened rendering behavior; no plugin functionality was dropped.Summary
bothsafely falls back to effectiveness and records whyPublic adaptations and exclusions
mainremain intactVerification
uv run pytest -q: 3,154 passed, 7 skipped, 3 deselecteduv run ruff check: passedtwine check --strict: passed for both distributionsA live remote Tier 3 Harbor/plugin evaluation was not run during reconstruction; the verified scope is the complete local suite, focused integration tests, packaging, and static boundary checks.
This PR is intentionally not merged.