chore: centralize frontier OpenAI/Anthropic chat defaults - #38
chore: centralize frontier OpenAI/Anthropic chat defaults#38chrisknvidia wants to merge 8 commits into
Conversation
Pin public chat defaults to gpt-5.5 / claude-opus-4-8 (Bedrock us.anthropic.claude-opus-4-8), keep gpt-5.4-mini as the documented cheap OpenAI override, and harden gpt-5* judge temperature/token handling. Addresses OpenClaw review feedback deferred from #33. Fixes #37 Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
rng1995
left a comment
There was a problem hiding this comment.
The model-default centralization and temperature handling look coherent, but this branch currently has one blocking OSS-boundary CI issue.
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
rng1995
left a comment
There was a problem hiding this comment.
Fresh review found two actionable issues in the OpenAI default/parameter migration. The existing OSS-boundary thread is already fixed and resolved; I will address these new findings and then update the branch from current main.
…tier-model-defaults Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
rng1995
left a comment
There was a problem hiding this comment.
Approved after fresh review and remediation. Both new P1 findings are fixed in bbbeae3, all review threads are resolved, the branch is current with main and conflict-free, local targeted/full/package/boundary verification passed, and the complete GitHub check matrix is green.
…tier-model-defaults Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com> # Conflicts: # CHANGELOG.md # config/oss_boundary_allowlist.json
rng1995
left a comment
There was a problem hiding this comment.
Approved on final head after updating from current main. Both conflicts are resolved, all review threads remain resolved, focused verification passes (404 tests), the full suite passes (3,669 passed, 13 skipped, 3 deselected), package and source/archive OSS-boundary checks pass, all 15 GitHub checks are green, and fresh merge-tree/GitHub audits report the PR conflict-free.
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
…tier-model-defaults Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com> # Conflicts: # CHANGELOG.md
Summary
gpt-5.4-mini) should be a frontier model — deferred from docs PR docs: clarify README launch overview and NVIDIA Build quickstart #33 into its own change (Fixes chore: centralize and update OpenAI/Anthropic frontier chat defaults #37).provider_config(CHAT_DEFAULT_*,CHAT_CHEAP_OPENAI,CHAT_DEFAULT_MODELS);constants.DIMENSION_JUDGE_MODELandllm_judge.DEFAULT_JUDGE_MODELimport from there. Harbortemplates/eval.pykeeps a local copy with drift tests.SKILL_EVAL_LLM_MODEL):gpt-5.6-solclaude-opus-4-8us.anthropic.claude-opus-4-8(AWS US geo inference profile)gpt-5.4-mini(CHAT_CHEAP_OPENAI)gpt-5*IDs for both temperature compatibility and native OpenAImax_completion_tokens; raises dimension/insights judgemax_tokensto 4096.Documentation parity
gpt-5.4-minidocumented as an explicit lower-cost override rather than a silent default.Before / after
gpt-5.4-minigpt-5.6-solclaude-sonnet-4-5claude-opus-4-8us.anthropic.claude-sonnet-4-5-20250929-v1:0us.anthropic.claude-opus-4-8SKILL_EVAL_LLM_MODELoverride are visibleTest plan
uv run pytest tests/test_provider_config.py tests/test_llm_judge.py tests/test_oss_packaging.py tests/test_provider_agent_routing.py tests/tier3/test_judge_parse_robustness.py tests/inference/test_llm_client.py tests/validators/test_security.py -q(457 passed)uv run pytest -q(3,091 passed, 8 skipped, 3 deselected)uv run ruff check .uv build --python 3.13 --no-sourcesscripts/check_oss_boundary.pyfern check(0 errors)