fix(quality): avoid substring false positives - #45
Conversation
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
Signed-off-by: Christopher Kevin <christopherk@nvidia.com>
rng1995
left a comment
There was a problem hiding this comment.
Two boundary/context false positives remain in this revision. Both are reproducible through the quality validator and should be covered before approval.
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
…e-30-keyword-boundaries Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
rng1995
left a comment
There was a problem hiding this comment.
Reviewed the final integrated diff at 3a3405e. Both remaining context false positives are fixed in 30c04be with regression coverage; all review threads are resolved. Local verification passed (158 focused validator tests; 3,175 full-suite tests; Ruff; OSS boundary), and all required GitHub Actions checks are green.
…e-30-keyword-boundaries Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com> # Conflicts: # CHANGELOG.md
rng1995
left a comment
There was a problem hiding this comment.
Approved after resolving the current main conflict at ec41fbc. The only conflict was CHANGELOG.md; the resolution preserves both PR #45’s boundary/context quality-scoring release note and main’s Tier 3 isolation release note, while all code changes from both sides remain intact. Final audit: git merge-tree is clean, all six review threads are resolved, the branch is mergeable, focused tests pass (158/158), all validator tests pass (732/732), the full suite passes (3753 passed, 13 skipped, 3 deselected), Ruff/diff/changed-file formatting pass, wheel/sdist build and Twine strict/OSS-boundary checks pass, and every final-SHA CI check is green. The transient Security classifier checkout certificate failure passed on the authorized failed-job rerun.
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
|
@chrisknvidia - I've already reviewed and approved this PR. Feel free to approve and merge on your end. |
Summary
Documentation parity
Before / after
Validation
142 passedfor quality and schema validators on Python 3.12142 passedfor quality and schema validators on Python 3.13716 passedacross all validator tests3142 passed, 7 skipped, 4 deselectedacross the repository; the one additional deselected bridge test cannot bind its fixed test port because a pre-existing local process owns127.0.0.1:18080fern checkpasses with 0 errorsCloses #30