Ignore short env values in secure Docker redaction - #51
Merged
chrisknvidia merged 2 commits intoAug 17, 2026
Merged
Conversation
Motivation: Tier 3 docker exec redaction treated every non empty environment value as a secret. Policy flags such as CLAUDE_CODE_DISABLE_POLICY_SKILLS=1 then rewrote every digit 1 in command output, corrupting NVIDIA Build bridge loopback origins during preflight. Modifications: Apply the existing eight character exact secret length floor in _redact and when collecting secret values for secure Docker exec. Add regression coverage for short flags versus real credentials. Result: Short env flags no longer destroy bridge health check origins, while longer credential values are still redacted from docker exec output. Signed-off-by: Hashim1999164 <64767361+Hashim1999164@users.noreply.github.com>
Hashim1999164
requested review from
chrisknvidia,
mosheabr,
rmalani-nv and
rng1995
as code owners
August 14, 2026 19:53
rng1995
approved these changes
Aug 17, 2026
rng1995
left a comment
rng1995
left a comment
Collaborator
There was a problem hiding this comment.
The minimum-length guard is applied both when collecting candidate values and when performing replacement, so short policy flags no longer corrupt Docker exec output while credential-length values remain redacted. The focused secure Docker environment tests pass locally (17 passed), Ruff passes on the changed Python files, and CI, Security, and DCO are green. No blocking findings.
Collaborator
|
Request @chrisknvidia to review the PR |
chrisknvidia
approved these changes
Aug 17, 2026
chrisknvidia
left a comment
chrisknvidia
left a comment
Collaborator
There was a problem hiding this comment.
This makes sense, Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tier 3 secure Docker exec redaction treated every non empty environment value as a secret. Policy flags such as CLAUDE_CODE_DISABLE_POLICY_SKILLS set to 1 then rewrote every digit 1 in command output, which corrupted NVIDIA Build bridge loopback origins during preflight.
This change applies the existing eight character exact secret length floor in
_redactand when collecting secret values, matchingllm_judgeand local environment redaction. Short flags no longer destroy bridge health check origins. Longer credential values remain redacted.Fixes #50
Verification
uv run pytestruff checkon the changed source and test files