style: apply ruff 0.15.2 formatting to drifted files (unblocks CI format check)#207
Open
wernerkasselman-au wants to merge 1 commit into
Open
Conversation
Four files were committed under an older ruff and no longer match `ruff format` under the pinned ruff 0.15.2 (uv.lock), so the CI `ruff format --check src/ tests/` job fails on main and on every PR branch regardless of its content. Reformat them to restore a clean check. No behaviour change: ruff format only adjusts whitespace and literal layout (for example, expanding a hand-condensed frozenset literal one element per line). Files: src/skillspector/nodes/analyzers/static_runner.py, tests/nodes/analyzers/test_binary_and_pe3_filtering.py, tests/nodes/analyzers/test_mp2_regex_backtracking.py, tests/nodes/test_llm_analyzer_base.py. Signed-off-by: Werner Kasselman <145896621+wernerkasselman-au@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
The CI
ruff format --check src/ tests/job is currently failing onmain, not on any one PR. Four files were committed under an older ruff and no longer matchruff formatunder the version this repo now pins (ruff>=0.15.0inpyproject.toml, whichuv.lockresolves to0.15.2), so the format job reports them as needing reformatting and exits non-zero. Because that check runs over the whole tree, every open PR inherits the red job regardless of what it changes. I hit it while getting CI green on two unrelated fixes (#204, #205), and it traces back tomainitself.The change
uv run ruff format src/ tests/, nothing more. It touches exactly the four drifted files and leaves the other 120 untouched:src/skillspector/nodes/analyzers/static_runner.py(a hand-condensedfrozenset({...})literal that 0.15.2 expands one element per line)tests/nodes/analyzers/test_binary_and_pe3_filtering.pytests/nodes/analyzers/test_mp2_regex_backtracking.pytests/nodes/test_llm_analyzer_base.pyNo behaviour change:
ruff formatonly adjusts whitespace and literal layout. I kept it to formatting on purpose so it is a safe, reviewable catch-up rather than mixing in anything else.Verification
If you would rather pin ruff to an exact version (so a future ruff bump does not re-introduce this drift on a
>=floor), I am happy to follow up with that separately; this PR just restores the clean check against the version already in the lock.