feat(analyzer): add phase-1 structured skill summaries#211
Open
rodboev wants to merge 3 commits into
Open
Conversation
Signed-off-by: Rod Boev <rod.boev@gmail.com>
Signed-off-by: Rod Boev <rod.boev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SkillSpector currently scans AISOP/AISP bundles as generic directories and never says that a structured workflow format was found or which workflow roles were present. This phase-1 slice teaches recursive discovery and build-context to recognize valid
*.aisop.jsonbundles, then emits one LOW informational summary finding without changing scoring or existing rule behavior.Refs #130
This follows the phased implementation sketch and AISOP/AISP bundle examples in #130.
Root cause
src/skillspector/multi_skill.pyonly recognizes rootSKILL.mdlayouts or immediate subdirectories that containSKILL.mdorskill.md, so--recursivemisses structured subdirectories that are expressed only through valid AISOP/AISP bundle files.src/skillspector/nodes/build_context.pybuilds generic scan context and never classifies those bundles, whilesrc/skillspector/nodes/analyzers/__init__.pyhas no structured-skill analyzer in the registry-driven graph. The bundle parser also needed to follow the issue schema itself, with workflow nodes atuser.content.functionsand constraint strings infunctions.*.constraints, rather than an invented nestedaisop.functionsshape. The result is simple: valid structured bundles can be scanned, but the report has no structured-skill summary surface at all.Diff Notes
src/skillspector/structured_skill.pyas the shared detector for valid*.aisop.jsonAISOP/AISP bundles and their summarized metadata, reading workflow nodes fromuser.content.functionsand AISP resources fromuser.content.aisp_contract.resources.src/skillspector/multi_skill.pyso--recursivecan treat immediate structured subdirectories as skills while preserving rootSKILL.mdprecedence.structured_skill_contextinsrc/skillspector/nodes/build_context.pyandsrc/skillspector/state.pywithout changing the public report schema.src/skillspector/nodes/analyzers/structured_skill_roles.pyand register it insrc/skillspector/nodes/analyzers/__init__.pyso the graph emits one LOWSSR-1structured summary finding.tests/test_multi_skill.py,tests/nodes/test_build_context.py,tests/nodes/analyzers/test_registry.py,tests/nodes/analyzers/test_structured_skill_roles.py, andtests/unit/test_cli.py.Scope
meta_analyzerchanges, and no changes to existing static, behavioral, MCP, or semantic findings.Findingfields.extensions/skillspector.ts.Verification
python -m pytest tests/test_multi_skill.py tests/nodes/test_build_context.py tests/nodes/analyzers/test_registry.py tests/nodes/analyzers/test_structured_skill_roles.py tests/unit/test_cli.py -q- pass,46 passed, 1 warninguv run ruff check src/ tests/- passuv run ruff format --check src/ tests/- passLint & Test (Python 3.12),Lint & Test (Python 3.13), andDCO Check- pending maintainer approval if fork checks are gatedNotes