fix: propagate CuTe DSL runtime link requirements for static libraries#103
Open
francismelon wants to merge 1 commit into
Open
fix: propagate CuTe DSL runtime link requirements for static libraries#103francismelon wants to merge 1 commit into
francismelon wants to merge 1 commit into
Conversation
Signed-off-by: francismelon <qq1650190803@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix
Overview:
This PR fixes CuTe DSL link propagation for static library targets.
Before this change,
cute_dsl_setup()did not propagate all CuTe DSL runtime compatibility pieces when the target type wasSTATIC_LIBRARY. As a result, downstream executables could fail during the final link step because they did not inherit all required link dependencies and options.This change updates the static-library path to propagate:
_cudaLaunchKernelExwrap linker option for CUDA< 12.8The existing private-link behavior for non-static targets is preserved.
Usage
This is a build-system fix only. No user-facing API or runtime usage change is introduced.
🚀 Pull Request Checklist
Thank you for contributing to TensorRT Edge-LLM! Before we review your pull request, please make sure the following items are complete.
Please also refer to Contributor guidelines for general guidelines.
✅ Pre-commit Checks
pre-commitby runningpip install pre-commit.pre-commit install.pre-commit run --all-filesand fixed any reported issues.🧪 Tests
📄 Documentation
⚙️ Compatibility
Additional Information
Reproduction environment
The issue was reproduced during cross-build configuration for Jetson Orin with:
-DCMAKE_BUILD_TYPE=Release-DTRT_PACKAGE_DIR=/usr-DCMAKE_TOOLCHAIN_FILE=cmake/aarch64_linux_toolchain.cmake-DEMBEDDED_TARGET=jetson-orin-DCUDA_CTK_VERSION=12.6-DENABLE_CUTE_DSL=ALLFailure before this fix
Before this change, the build failed at the final executable link step for
llm_inferencewith unresolved CuTe DSL CUDA runtime symbols:Validation after this fix
Validation performed locally:
pre-commit run --files cmake/CuteDsl.cmakecmake .. -DCMAKE_BUILD_TYPE=Release -DTRT_PACKAGE_DIR=/usr -DCMAKE_TOOLCHAIN_FILE=cmake/aarch64_linux_toolchain.cmake -DEMBEDDED_TARGET=jetson-orin -DCUDA_CTK_VERSION=12.6 -DENABLE_CUTE_DSL=ALLRelevant successful outputs after this fix included:
Risk
Low. The change only adjusts link visibility and propagation for CuTe DSL-related dependencies and link options for static-library targets, while preserving the existing behavior for non-static targets.