[None][fix] Enable LoRA in EAGLE3 speculative decoding#13005
Draft
Funatiq wants to merge 2 commits intoNVIDIA:mainfrom
Draft
[None][fix] Enable LoRA in EAGLE3 speculative decoding#13005Funatiq wants to merge 2 commits intoNVIDIA:mainfrom
Funatiq wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Collaborator
Author
|
/bot run |
Funatiq
changed the title
Collaborator
|
PR_Github #43093 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #43093 [ run ] completed with state
|
- Handle optional PEFT cache manager in AdapterSlotManager and update weight pointers in CudaGraphLoraParams. - Add unit tests for CudaGraphLoraParams and AdapterSlotManager to validate behavior when PEFT cache manager is missing. - Add integration test for LoRA in EAGLE3 speculative decoding with and without CUDA graph. Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
Signed-off-by: Robin Kobus <19427718+Funatiq@users.noreply.github.com>
Funatiq
force-pushed
the
dev/fix/eagle_lora
branch
from
bca258d to
a7e50d9
Compare
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #43108 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #43108 [ run ] completed with state
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.