Skip to content

[None][fix] fix Wan unit tests#13026

Merged
yuanjingx87 merged 1 commit intoNVIDIA:mainfrom
zhenhuaw-me:fix-CI
Apr 14, 2026
Merged

[None][fix] fix Wan unit tests#13026
yuanjingx87 merged 1 commit intoNVIDIA:mainfrom
zhenhuaw-me:fix-CI

Conversation

@zhenhuaw-me
Copy link
Copy Markdown
Member

@zhenhuaw-me zhenhuaw-me commented Apr 14, 2026

Summary by CodeRabbit

  • Tests
    • Updated CFG parallel validation tests to use correct field references, ensuring proper rank mapping verification and prompt selection logic in visual generation workflows.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Zhenhua Wang <zhenhuaw@nvidia.com>
@zhenhuaw-me
Copy link
Copy Markdown
Member Author

/bot run

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b4fedeec-0194-4b5a-bb02-e7ba12e795c9

📥 Commits

Reviewing files that changed from the base of the PR and between bdd5ec6 and a398b8f.

📒 Files selected for processing (2)
  • tests/unittest/_torch/visual_gen/test_wan.py
  • tests/unittest/_torch/visual_gen/test_wan_i2v.py

📝 Walkthrough

Walkthrough

Test files for visual generation models updated to use cfg_rank instead of cfg_group for CFG parallelism validation, affecting rank-to-prompt mapping assertions, embedding selection logic, and diagnostic logging in worker functions.

Changes

Cohort / File(s) Summary
CFG Parallelism Test Updates
tests/unittest/_torch/visual_gen/test_wan.py, tests/unittest/_torch/visual_gen/test_wan_i2v.py
Updated assertions and diagnostic logic in _run_cfg_worker and _run_cfg_worker_i2v functions to use cfg_rank instead of cfg_group for rank-to-prompt mapping verification, embedding selection comparisons, and rank-0 debug logging.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description consists entirely of the template with placeholders and no actual content filled in for Description or Test Coverage sections. Fill in the Description section explaining what was fixed and why, and the Test Coverage section listing relevant tests that verify the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '[None][fix] fix Wan unit tests' follows the required format and correctly identifies the change as a fix to unit tests for the Wan module.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43197 [ run ] triggered by Bot. Commit: a398b8f Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43197 [ run ] completed with state DISABLED
Freeze main and open the PR merge only after CI is back to healthy https://nvidia.slack.com/archives/C059LSY62BT/p1776141760843319?thread_ts=1775985925.442509&cid=C059LSY62BT

Link to invocation

@litaotju
Copy link
Copy Markdown
Collaborator

/bot run --disable-fail-fast

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43205 [ run ] triggered by Bot. Commit: a398b8f Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43205 [ run ] completed with state SUCCESS. Commit: a398b8f
/LLM/main/L0_MergeRequest_PR pipeline #33805 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@litaotju
Copy link
Copy Markdown
Collaborator

/bot help

@github-actions
Copy link
Copy Markdown

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

Details

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental) --high-priority]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

--high-priority (OPTIONAL) : Run the pipeline with high priority. This option is restricted to authorized users only and will route the job to a high-priority queue.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@litaotju
Copy link
Copy Markdown
Collaborator

/bot run --reuse-test --stage-list DGX_B200-4_GPUs-PyTorch-2

@litaotju
Copy link
Copy Markdown
Collaborator

/bot run --reuse-test --stage-list "DGX_B200-4_GPUs-PyTorch-2"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43239 [ run ] triggered by Bot. Commit: a398b8f Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43241 [ run ] triggered by Bot. Commit: a398b8f Link to invocation

@brb-nv brb-nv enabled auto-merge (squash) April 14, 2026 16:25
@yuanjingx87 yuanjingx87 disabled auto-merge April 14, 2026 16:29
@yuanjingx87 yuanjingx87 merged commit 6865d05 into NVIDIA:main Apr 14, 2026
8 of 10 checks passed
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43241 [ run ] completed with state SUCCESS. Commit: a398b8f
/LLM/main/L0_MergeRequest_PR pipeline #33809 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants