Skip to content

[None][chore] Waive failed tests#13035

Merged
nv-guomingz merged 2 commits intoNVIDIA:mainfrom
yiqingy0:waive_tests
Apr 14, 2026
Merged

[None][chore] Waive failed tests#13035
nv-guomingz merged 2 commits intoNVIDIA:mainfrom
yiqingy0:waive_tests

Conversation

@yiqingy0
Copy link
Copy Markdown
Collaborator

@yiqingy0 yiqingy0 commented Apr 14, 2026

Summary by CodeRabbit

  • Tests
    • Updated test configurations for specific model deployment scenarios.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
@yiqingy0
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Waive tests"

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 93eabfbf-6c89-4ef3-a1a5-c56ca21707a7

📥 Commits

Reviewing files that changed from the base of the PR and between f2f9051 and e62cc65.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt

📝 Walkthrough

Walkthrough

Two new SKIP entries are added to the test waives list, targeting specific parameterized test cases with defined configurations: one for a DeepSeek model test with TRTLLM backend and one for a Nemotron model test with specific dtype and backend settings.

Changes

Cohort / File(s) Summary
Test Waiver Configuration
tests/integration/test_lists/waives.txt
Added two SKIP entries for parameterized test cases: TestDeepSeekV3Lite::test_nvfp4_4gpus with moe_backend=TRTLLM and TestNemotronH::test_auto_dtype with trtllm-flashinfer_ssm-False.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description consists entirely of the template with no custom content provided. All sections like Description, Test Coverage, and checklist items are either empty or unchecked, failing to explain the issue, solution, or test coverage. Add a Description section explaining which tests are being waived and why, and provide Test Coverage information for the changes made to waives.txt.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title '[None][chore] Waive failed tests' clearly and concisely describes the main change: adding test waiver entries to skip failing tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43216 [ skip ] triggered by Bot. Commit: e62cc65 Link to invocation

Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43216 [ skip ] completed with state SUCCESS. Commit: e62cc65
Skipping testing for commit e62cc65

Link to invocation

@yiqingy0
Copy link
Copy Markdown
Collaborator Author

/bot skip --comment "Waive tests"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43217 [ skip ] triggered by Bot. Commit: 33ba4f6 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #43217 [ skip ] completed with state SUCCESS. Commit: 33ba4f6
Skipping testing for commit 33ba4f6

Link to invocation

@nv-guomingz nv-guomingz merged commit e60dd57 into NVIDIA:main Apr 14, 2026
5 checks passed
@yiqingy0 yiqingy0 deleted the waive_tests branch April 14, 2026 12:38
chienchunhung pushed a commit to chienchunhung/TensorRT-LLM that referenced this pull request Apr 16, 2026
Signed-off-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
Co-authored-by: yiqingy <yiqingy@tensorrt-llm-infra-debug-vm-01.nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants