cuda.core.system: add conveniences to convert between device types #1508
+94
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
mdboom
force-pushed
the
cuda.core.system-convert-devices
branch
from
922270e to
23aefa3
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds convenience methods to convert between cuda.core.Device (CUDA API) and cuda.core.system.Device (NVML API), enabling easier interoperability between the two device types.
Changes:
- Added
to_system_device()method tocuda.core.Devicefor converting to NVML device representation - Added
to_cuda_device()method tocuda.core.system.Devicefor converting to CUDA device representation - Added comprehensive tests for both conversion methods
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cuda_core/cuda/core/_device.pyx | Implements to_system_device() method for converting CUDA Device to system Device using UUID mapping |
| cuda_core/cuda/core/system/_device.pyx | Implements to_cuda_device() method for converting system Device to CUDA Device by searching all devices for matching UUID |
| cuda_core/tests/test_device.py | Adds test for to_system_device() conversion, verifying UUID and PCI bus ID mapping |
| cuda_core/tests/system/test_system_device.py | Adds test for to_cuda_device() conversion across all devices, verifying UUID and PCI bus ID mapping |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
/ok to test |
|
Contributor
Author
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two convenience methods to convert between
cuda.core.Deviceandcuda.core.system.Device.I have a few design questions for this one:
Device.to_system_deviceandDevice.to_cuda_deviceok?cuda.core.Device(nvml_device), but that requires importing the other module from the constructor which could be a performance / cyclical import nightmare.