cuda.bindings.nvml: Simplify the "#defines as enums" naming #1509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request simplifies the naming convention for manually-written enums in cuda.bindings.nvml by removing redundant prefixes from enum member names. Since Python enums provide their own namespace, the common prefixes that were necessary in C (where these were #defines) are no longer needed.
Changes:
- Simplified enum member names by removing redundant prefixes (e.g.,
EVENT_TYPE_SINGLE_BIT_ECC_ERROR→SINGLE_BIT_ECC_ERROR) - Updated test references to use the new simplified enum names
- Updated documentation references to use the new enum names
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cuda_bindings/cuda/bindings/_nvml.pyx | Simplified enum member names across ~30 enum classes by removing redundant prefixes |
| cuda_core/tests/system/test_system_device.py | Updated test to use new EventType enum names without EVENT_TYPE_ prefix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/ok to test |
|
Member
|
Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cuda.bindings.nvml has a bunch of enums which are written by hand because they are
#definesin the nvml header. In hindsight, these didn't all need full names, but the common prefixes of the individual values can be removed. (Since Python enums are a namespace, unlike C, the prefixes aren't necessary).