Migrate pynvml.py to cuda.core.system - #8022
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughUpdates dependency declarations to add Changespynvml to cuda.core.system migration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@mdboom Is it safe to assume that this can wait to be release in 26.08 rather than 26.06? |
Yes. There is no concrete timeline to deprecate pynvml, so no urgency on this. |
betatim
left a comment
There was a problem hiding this comment.
One question about how things will work for packages built for different cuda versions. Otherwise looks fine to me
| - numpydoc<1.9 | ||
| # 'nvidia-ml-py' provides the 'pynvml' module | ||
| - nvidia-ml-py>=12 | ||
| - cuda-bindings>=12.9.6,!=13.0.*,!=13.1.* |
There was a problem hiding this comment.
Do the versions here correspond to the version of CUDA that the user has installed?
Will this also work for the -cu13 package that we upload to pypi?
|
Can you merge the latest changes from |
Migrates usage of pynvml.py to the new Cython and cybind-based cuda.core.system.
I was unable to get my environment set up to test this locally, so there may be issues.