Skip to content

Remove stale single-GPU test xfails #8450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
csadorf wants to merge 4 commits into
base: main
Choose a base branch
from
+2 −10
Draft

Remove stale single-GPU test xfails #8450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1b0420
Remove stale metrics and clustering xfails
csadorf Aug 5, 2026
cf55c99
Remove stale sparse t-SNE xfails
csadorf Aug 5, 2026
2c144f5
Remove stale UMAP xfails
csadorf Aug 5, 2026
8ad8e2c
Restore UMAP outlier xfail
csadorf Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion python/cuml/tests/test_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,6 @@ def test_silhouette_samples_batched(metric, chunk_divider, labeled_clusters):
assert False


@pytest.mark.xfail
def test_silhouette_score_batched_non_monotonic():
vecs = np.array(
[[0.0, 0.0, 0.0], [1.0, 1.0, 1.0], [2.0, 2.0, 2.0], [10.0, 10.0, 10.0]]
Expand Down
3 changes: 1 addition & 2 deletions python/cuml/tests/test_spectral_clustering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION.
# SPDX-FileCopyrightText: Copyright (c) 2025-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
#

Expand Down Expand Up @@ -243,7 +243,6 @@ def test_precomputed_matrix_formats(converter, dtype):
assert ari > min_ari


@pytest.mark.xfail(reason="https://github.com/rapidsai/cuml/issues/7714")
@given(
n_samples=st.integers(min_value=100, max_value=2000),
n_features=st.integers(min_value=2, max_value=20),
Expand Down
1 change: 0 additions & 1 deletion python/cuml/tests/test_tsne.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,6 @@ def test_tsne_distance_metrics(metric):
assert array_equal(sk_trust, cuml_trust, 0.05, with_sign=True)


@pytest.mark.xfail(reason="https://github.com/rapidsai/cuml/issues/6682")
@pytest.mark.parametrize("method", ["fft", "barnes_hut", "exact"])
@pytest.mark.parametrize(
"metric", ["l2", "euclidean", "cityblock", "l1", "manhattan", "cosine"]
Expand Down
7 changes: 1 addition & 6 deletions python/cuml/tests/test_umap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,7 @@ def test_blobs_cluster(nrows, n_feats, build_algo):
[
pytest.param(
500,
marks=[
pytest.mark.unit,
pytest.mark.xfail(
reason="https://github.com/rapidsai/cuvs/issues/184"
),
],
marks=pytest.mark.unit,
),
quality_param(5000),
stress_param(500000),
Expand Down
Loading