Conversation
46474dd to
6ebb74e
Compare
|
The handler type is not meant for an end user. Users are meant to invoke this as You use it as: device.GetTemperatureV(sensorType).V1() And in the future (if there is ever a v2 struct) as: device.GetTemperatureV(sensorType).V2() |
6ebb74e to
39616e6
Compare
I am grateful for the answer! My bad for disturbing you, just wanted to help |
|
No worries. I believe you did in fact uncover a bug, because the input parameters of the struct aren't being passed in like I suggest in my response. So your fix was incorrect, but the bug is real. |
Yeah, i re-open my PR to say about it : - D I want to fix this bug, can you please help me with youre review? I do my implementation, you say if maybe i need to change something, and we will get great working code (already made the changes ⚡ ) |
39616e6 to
67251bf
Compare
The original (C) nvml let user specify what type of temperature sensor he want to query. This is why we change GO implementation, and user can call the functions with familiar manner. Signed-off-by: Dmitrii Chervov <dschervov@yandex-team.ru>
67251bf to
4c9b011
Compare
Restored default nvml api
The original (C) nvml let user specify what
type of temperature sensor he want to query.
This is why we change GO implementation, and
user can call the functions with familiar
manner.
Signed-off-by: Dmitrii Chervov dschervov@yandex-team.ru