Skip to content

Restored default nvml api#175

Open
dschervov wants to merge 1 commit intoNVIDIA:mainfrom
dschervov:bring-back-original-nvml-api-for-temperature-query
Open

Restored default nvml api#175
dschervov wants to merge 1 commit intoNVIDIA:mainfrom
dschervov:bring-back-original-nvml-api-for-temperature-query

Conversation

@dschervov
Copy link
Copy Markdown

@dschervov dschervov commented Apr 6, 2026

Restored default nvml api
The original (C) nvml let user specify what
type of temperature sensor he want to query.

This is why we change GO implementation, and
user can call the functions with familiar
manner.

Signed-off-by: Dmitrii Chervov dschervov@yandex-team.ru

@dschervov dschervov force-pushed the bring-back-original-nvml-api-for-temperature-query branch from 46474dd to 6ebb74e Compare April 6, 2026 20:30
@klueska
Copy link
Copy Markdown
Collaborator

klueska commented Apr 6, 2026

The handler type is not meant for an end user.

Users are meant to invoke this as You use it as:

device.GetTemperatureV(sensorType).V1()

And in the future (if there is ever a v2 struct) as:

device.GetTemperatureV(sensorType).V2()

@dschervov dschervov force-pushed the bring-back-original-nvml-api-for-temperature-query branch from 6ebb74e to 39616e6 Compare April 6, 2026 21:15
@dschervov
Copy link
Copy Markdown
Author

The handler type is not meant for an end user.

Users are meant to invoke this as You use it as:

device.GetTemperatureV(sensorType).V1()

And in the future (if there is ever a v2 struct) as:

device.GetTemperatureV(sensorType).V2()

I am grateful for the answer! My bad for disturbing you, just wanted to help

@dschervov dschervov closed this Apr 6, 2026
@dschervov dschervov reopened this Apr 6, 2026
@klueska
Copy link
Copy Markdown
Collaborator

klueska commented Apr 6, 2026

No worries. I believe you did in fact uncover a bug, because the input parameters of the struct aren't being passed in like I suggest in my response. So your fix was incorrect, but the bug is real.

@dschervov
Copy link
Copy Markdown
Author

dschervov commented Apr 6, 2026

No worries. I believe you did in fact uncover a bug, because the input parameters of the strict aren't being passed in like I suggest in my response. So your fix was incorrect, but the bug is real.

Yeah, i re-open my PR to say about it : - D

I want to fix this bug, can you please help me with youre review? I do my implementation, you say if maybe i need to change something, and we will get great working code (already made the changes ⚡ )

@dschervov dschervov force-pushed the bring-back-original-nvml-api-for-temperature-query branch from 39616e6 to 67251bf Compare April 6, 2026 21:55
The original (C) nvml let user specify what
type of temperature sensor he want to query.

This is why we change GO implementation, and
user can call the functions with familiar
manner.

Signed-off-by: Dmitrii Chervov <dschervov@yandex-team.ru>
@dschervov dschervov force-pushed the bring-back-original-nvml-api-for-temperature-query branch from 67251bf to 4c9b011 Compare April 6, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants