Skip to content

Clean up debug printlns in api-core#2648

Open
kensimon wants to merge 1 commit into
NVIDIA:mainfrom
kensimon:cleanup-debug-printlns
Open

Clean up debug printlns in api-core#2648
kensimon wants to merge 1 commit into
NVIDIA:mainfrom
kensimon:cleanup-debug-printlns

Conversation

@kensimon

Copy link
Copy Markdown
Contributor

Some println!()'s were left in the update_instance_config handlers, convert them to tracing::info!.

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

@kensimon kensimon requested a review from a team as a code owner June 16, 2026 16:58
@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8f4df40a-1e9e-4a5f-aebb-9117dafe6721

📥 Commits

Reviewing files that changed from the base of the PR and between 3e99dd2 and 7297ba7.

📒 Files selected for processing (1)
  • crates/api-core/src/handlers/instance.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use zizmor to find security issues in GitHub Actions workflow files.

Assertive reviews run zizmor with --pedantic for stricter GitHub Actions security checks. See the zizmor documentation for audit details.

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown

🔍 Container Scan Summary

Service Total Critical High Medium Low Other
boot-artifacts-aarch64 3 0 0 3 0 0
boot-artifacts-x86_64 3 0 0 3 0 0
forge-admin-cli-x86_64 244 4 22 103 6 109
machine-validation-runner 671 23 178 262 37 171
machine_validation 671 23 178 262 37 171
nvmetal-carbide 671 23 178 262 37 171
TOTAL 2263 73 556 895 117 622

Per-CVE detail lives in the per-service grype-* artifacts (JSON + SARIF). Severity counts only — no CVE IDs published here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants