Skip to content

Fix ignored file in devspace build #2663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kensimon wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

Fix ignored file in devspace build #2663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dev/deployment/devspace/Dockerfile.api.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@
!include/
!include/**
!pxe
pxe/**
!pxe/templates
!pxe/templates/
!pxe/templates/**
!pxe/
!pxe/ipxe/
!pxe/ipxe/local/
!pxe/ipxe/local/embed.ipxe
1 change: 1 addition & 0 deletions dev/deployment/devspace/Dockerfile.bmc-proxy.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@
!crates
!crates/
!crates/**
!pxe/ipxe/local/embed.ipxe

@coderabbitai coderabbitai Bot Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify pxe/ipxe/local/embed.ipxe is in the bmc-proxy build context
# Expected: The file should be accessible in the Docker build context without errors

# Check the .dockerignore rules and confirm the file is not excluded
grep -E "^pxe|embed\.ipxe" dev/deployment/devspace/.dockerignore dev/deployment/devspace/Dockerfile.bmc-proxy.dockerignore

Repository: NVIDIA/infra-controller

Length of output: 241

🏁 Script executed:

# Check if the pxe/ipxe/local/embed.ipxe file actually exists
fd -type f "embed.ipxe"

Repository: NVIDIA/infra-controller

Length of output: 238

🏁 Script executed:

# Look for .dockerignore files in the repository
fd -type f "\.dockerignore$"

Repository: NVIDIA/infra-controller

Length of output: 238

🏁 Script executed:

# Examine the Dockerfile.api.dockerignore and Dockerfile.machine-a-tron.dockerignore 
# to see the hierarchical un-ignores pattern mentioned in the review
fd -type f "Dockerfile\.\w+\.dockerignore$" -exec cat {} +

Repository: NVIDIA/infra-controller

Length of output: 238

🏁 Script executed:

# Check if there's a root-level .dockerignore that might be blocking pxe/
cat .dockerignore 2>/dev/null || echo "No root .dockerignore found"

Repository: NVIDIA/infra-controller

Length of output: 427

🏁 Script executed:

# Find the embed.ipxe file
find . -name "embed.ipxe" -type f

Repository: NVIDIA/infra-controller

Length of output: 95

🏁 Script executed:

# Find all .dockerignore files
find dev/deployment/devspace -name "*.dockerignore" -type f

Repository: NVIDIA/infra-controller

Length of output: 240

🏁 Script executed:

# Examine the referenced .dockerignore files
cat dev/deployment/devspace/Dockerfile.api.dockerignore
cat dev/deployment/devspace/Dockerfile.machine-a-tron.dockerignore

Repository: NVIDIA/infra-controller

Length of output: 543

🏁 Script executed:

# Show the full content of Dockerfile.bmc-proxy.dockerignore
cat dev/deployment/devspace/Dockerfile.bmc-proxy.dockerignore

Repository: NVIDIA/infra-controller

Length of output: 213

Add hierarchical un-ignores for the nested pxe/ipxe/local/embed.ipxe file in Dockerfile.bmc-proxy.dockerignore.

The .dockerignore file ignores all files (**) at the top level, then attempts to un-ignore !pxe/ipxe/local/embed.ipxe. However, Docker's .dockerignore semantics require parent directories to be explicitly un-ignored before a nested file can be accessed. The corresponding Dockerfile.api.dockerignore and Dockerfile.machine-a-tron.dockerignore files correctly include the hierarchical un-ignores (!pxe/, !pxe/ipxe/, !pxe/ipxe/local/) that are absent from this file.

Update dev/deployment/devspace/Dockerfile.bmc-proxy.dockerignore to include:

!pxe/
!pxe/ipxe/
!pxe/ipxe/local/
!pxe/ipxe/local/embed.ipxe

This ensures consistency across all three Dockerfile-specific .dockerignore files and guarantees the file is properly included in the Docker build context.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@dev/deployment/devspace/Dockerfile.bmc-proxy.dockerignore` at line 12, The
Dockerfile.bmc-proxy.dockerignore file is missing hierarchical un-ignore
patterns needed for Docker to properly access the nested embed.ipxe file. Add
the parent directory un-ignore patterns before the final file un-ignore: insert
!pxe/ on a new line before !pxe/ipxe/local/embed.ipxe, then add !pxe/ipxe/ on
the next line, then add !pxe/ipxe/local/ on the next line, and keep
!pxe/ipxe/local/embed.ipxe as the final un-ignore pattern. This mirrors the
hierarchical structure already present in Dockerfile.api.dockerignore and
Dockerfile.machine-a-tron.dockerignore and ensures Docker's .dockerignore
semantics properly un-ignore parent directories before attempting to access the
nested file.

4 changes: 4 additions & 0 deletions dev/deployment/devspace/Dockerfile.machine-a-tron.dockerignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,7 @@
!include
!include/
!include/**
!pxe/
!pxe/ipxe/
!pxe/ipxe/local/
!pxe/ipxe/local/embed.ipxe
Comment on lines +15 to +18

@coderabbitai coderabbitai Bot Jun 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Cross-check pxe asset patterns across all three devspace dockerignore files
# Expected: Consistent un-ignore patterns or documented rationale for differences

echo "=== Dockerfile.api.dockerignore ==="
grep "^!" dev/deployment/devspace/Dockerfile.api.dockerignore | grep "pxe"

echo ""
echo "=== Dockerfile.bmc-proxy.dockerignore ==="
grep "^!" dev/deployment/devspace/Dockerfile.bmc-proxy.dockerignore | grep "pxe"

echo ""
echo "=== Dockerfile.machine-a-tron.dockerignore ==="
grep "^!" dev/deployment/devspace/Dockerfile.machine-a-tron.dockerignore | grep "pxe"

Repository: NVIDIA/infra-controller

Length of output: 397

Align dockerignore patterns across all three devspace build contexts.

The three devspace Dockerfile build contexts employ substantively different patterns for including PXE assets:

  • Dockerfile.api.dockerignore includes a broad set of patterns: !pxe, !pxe/templates (with variants), and the hierarchical !pxe/ipxe/local/ structure culminating in !pxe/ipxe/local/embed.ipxe
  • Dockerfile.machine-a-tron.dockerignore uses a hierarchical approach: !pxe/, !pxe/ipxe/, !pxe/ipxe/local/, then the specific file
  • Dockerfile.bmc-proxy.dockerignore includes only the minimal pattern: !pxe/ipxe/local/embed.ipxe

This fragmentation across build contexts creates maintenance friction and makes it difficult to reason about whether each context correctly excludes/includes its required assets. Adopt a consistent pattern across all three files, or document in code comments why each diverges (e.g., if bmc-proxy has different asset requirements than the others).

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@dev/deployment/devspace/Dockerfile.machine-a-tron.dockerignore` around lines
15 - 18, The three devspace dockerignore files (Dockerfile.api.dockerignore,
Dockerfile.machine-a-tron.dockerignore, and Dockerfile.bmc-proxy.dockerignore)
use inconsistent patterns for including PXE assets. Either standardize all three
files to use the same pattern (such as the hierarchical approach with !pxe/,
!pxe/ipxe/, !pxe/ipxe/local/, and !pxe/ipxe/local/embed.ipxe), or add clear code
comments in each file explaining why its specific pattern differs from the
others (for example, if bmc-proxy genuinely requires fewer assets). Ensure the
choice aligns with the actual asset requirements of each build context to
eliminate maintenance friction.

Loading