Conversation
Signed-off-by: Jakub Klinkovský <1289205+lahwaacz@users.noreply.github.com>
…file Signed-off-by: Jakub Klinkovský <1289205+lahwaacz@users.noreply.github.com>
…ng their own flags For example, Arch Linux wants debug information in the binaries. Signed-off-by: Jakub Klinkovský <1289205+lahwaacz@users.noreply.github.com>
For example, Arch Linux strips debug information after build during the package creation and producing separate debug info files during the build interferes with the Arch tooling. Signed-off-by: Jakub Klinkovský <1289205+lahwaacz@users.noreply.github.com>
…SECCOMP "yes" means linking to system libtirpc, "no" means building libtirpc from source. Signed-off-by: Jakub Klinkovský <1289205+lahwaacz@users.noreply.github.com>
Author
|
@elezar Can you look at this please? 🙏 |
Member
|
@lahwaacz sorry for the delay. I will have a look. |
elezar
requested changes
May 23, 2024
Member
elezar
left a comment
elezar
left a comment
There was a problem hiding this comment.
Thanks for the changes.
I think they look good. The one thing missing is ensuring that the defaults for all major platforms are the same given the WITH_TIRPC changes.
Author
|
@elezar Any progress with merging this? It's been almost half a year... |
Author
|
@elezar It has been a year, can you merge this please? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes make building with system flags and libs more straightforward or actually possible. I had to patch the build system a lot while making a package for Arch Linux.