charts/agent: Run hardware discovery in init container#857
Draft
DrewBloechl wants to merge 4 commits intoNVIDIA:mainfrom
Draft
charts/agent: Run hardware discovery in init container#857DrewBloechl wants to merge 4 commits intoNVIDIA:mainfrom
DrewBloechl wants to merge 4 commits intoNVIDIA:mainfrom
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
| {{- toYaml .Values.podSecurityContext | nindent 8 }} | ||
| initContainers: | ||
| - name: forge-dpu-agent-init | ||
| securityContext: |
Contributor
There was a problem hiding this comment.
it will need extra permissions, right?
Contributor
Author
There was a problem hiding this comment.
Yeah, I just pushed a change that sets:
procMount: Unmasked
privileged: true...but this is still untested and there might be a more specific set of capabilities that we can grant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Run the hardware discovery code from an init container. This will need some permissions (TBD) granted so that the init container can see the hardware details it needs.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes