fix(helm): promote database ConfigMap to pre-install hook#877
Merged
ianderson-nvidia merged 1 commit intoNVIDIA:mainfrom Apr 13, 2026
Merged
Conversation
The `carbide-api-migrate` Job is a `pre-install,pre-upgrade` hook at weight `-5`. It references `forge-system-carbide-database-config` for DB connection details, but that ConfigMap was a regular Helm-managed resource — not a hook. Helm creates hooks before non-hook resources, so the ConfigMap didn't exist when the migration pod started, causing pod errors on every fresh `helm install`. Add Helm hook annotations to the database ConfigMap: - `helm.sh/hook: pre-install,pre-upgrade` — create the ConfigMap during hook phase alongside the migration job - `helm.sh/hook-weight: "-10"` — Create the ConfigMap before the migration job at `-5` - `helm.sh/hook-delete-policy: before-hook-creation` — recreate the ConfigMap on each install/upgrade - `helm.sh/resource-policy: keep` — Do not delete the ConfigMap after hook phase so the main deployment can still reference it Closes NVIDIA#773
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-04-09 19:25:38 UTC | Commit: b6458e6 |
bryan-aguilar
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
carbide-api-migrateJob is apre-install,pre-upgradehook at weight-5. It referencesforge-system-carbide-database-configfor DB connection details, but that ConfigMap was a regular Helm-managed resource — not a hook. Helm creates hooks before non-hook resources, so the ConfigMap didn't exist when the migration pod started, causing pod errors on every freshhelm install.Add Helm hook annotations to the database ConfigMap:
helm.sh/hook: pre-install,pre-upgrade— create the ConfigMap during hook phase alongside the migration jobhelm.sh/hook-weight: "-10"— Create the ConfigMap before the migration job at-5helm.sh/hook-delete-policy: before-hook-creation— recreate the ConfigMap on each install/upgradehelm.sh/resource-policy: keep— Do not delete the ConfigMap after hook phase so the main deployment can still reference itCloses #773