feat: drive all DPF mandatory services from per-service config with compile-time defaults#896
Open
abvarshney-nv wants to merge 2 commits intoNVIDIA:mainfrom
Open
feat: drive all DPF mandatory services from per-service config with compile-time defaults#896abvarshney-nv wants to merge 2 commits intoNVIDIA:mainfrom
abvarshney-nv wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
wminckler
reviewed
Apr 16, 2026
wminckler
approved these changes
Apr 16, 2026
abvarshney-nv
force-pushed
the
version_handling_dpf
branch
from
ac2867c to
58895ac
Compare
abvarshney-nv
changed the title
wminckler
approved these changes
Apr 21, 2026
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-04-21 11:13:39 UTC | Commit: 58895ac |
aadvani-nvidia
approved these changes
Apr 21, 2026
abvarshney-nv
force-pushed
the
version_handling_dpf
branch
2 times, most recently
from
f6d56b0 to
8e4ac59
Compare
Signed-off-by: abhi <abvarshney@nvidia.com>
Introduces DpfMandatoryServiceConfig with named fields (dpu_agent, dhcp_server, fmds, otel), each carrying its own helm/docker coordinates and serde defaults seeded from compile-time constants. Update the dpu_agent_service and dhcp_server_service to take &DpfServiceConfig directly; adds fmds_service and otel_service. Removes CarbideServiceRegistryConfig::from_runtime, the derived Default, and the now-redundant carbide_helm_version/carbide_image_tag config fields. setup.rs v2_services is rewired to consume DpfMandatoryServiceConfig instead of the registry struct.
abvarshney-nv
force-pushed
the
version_handling_dpf
branch
from
8e4ac59 to
29a36c1
Compare
aadvani-nvidia
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces the flat
CarbideServiceRegistryConfigstruct withDpfMandatoryServicesConfig, a typed config struct where each of the six mandatory DPF services (dts,doca_hbn,dpu_agent,dhcp_server,fmds,otel) has its ownDpfServiceConfigcarrying its helm repo/chart/version and docker repo/tag independentlyAdds
docker_repo_urlanddocker_image_tagfields toDpfServiceConfigso image coordinates are first-class alongside helm coordinatesService builder functions (
doca_hbn_service,dpu_agent_service,dhcp_server_service) now accept&DpfServiceConfigdirectly; newdts_service,fmds_service, andotel_servicebuilders added with the same signaturePer-service defaults live in
dpf_services.rsnext to their constants; Carbide-owned services (dpu_agent,dhcp_server) seedhelm_versionanddocker_image_tagfrom compile-time CI env vars (CARBIDE_BUILD_HELM_VERSION/CARBIDE_BUILD_GIT_TAG)Removes the now-redundant
carbide_helm_versionandcarbide_image_tagtop-level config fields, and theCarbideServiceRegistryConfig::from_runtimefallback pathsetup.rsv1 and v2 service lists are both built entirely fromDpfMandatoryServicesConfig, removing the last direct call tocarbide_dpf::services::dts_serviceOn CI (main): VERSION env var → compile-time version baked in → correct
helm chart and image pulled automatically.
On PR/fork: compile-time version is empty; set carbide_helm_version /
carbide_image_tag in config to test against a published version.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes