Open
Conversation
thossain-nv
requested review from
hwadekar-nv,
kfelternv,
parmani-nv and
pbreton
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (234)
✅ Files skipped from review due to trivial changes (210)
🚧 Files skipped from review as they are similar to previous changes (21)
Summary by CodeRabbit
WalkthroughBumps project version to v1.3.0 across metadata, Helm chart, OpenAPI spec, and generated SDK files; updates CHANGELOG with v1.3.0 entries; adds optional Labels maps to several expected-resource and InfiniBand request models; and minor SDK client utility change to ensure file closure. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
|
Signed-off-by: Tareque Hossain <thossain@nvidia.com>
Signed-off-by: Tareque Hossain <thossain@nvidia.com>
thossain-nv
force-pushed
the
version/1.3.0
branch
from
340ca8c to
6ee7255
Compare
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-04-14 00:30:34 UTC | Commit: 6ee7255 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@helm/charts/carbide-rest/Chart.yaml`:
- Around line 5-6: The Chart.yaml was updated to change appVersion to "1.3.0"
but the chart version was not incremented; update the Chart.yaml "version" field
to a new semantically appropriate chart version (e.g., increment patch from
0.1.5 to 0.1.6 or follow your chart versioning scheme) so that consumers can
detect the chart update—edit the Chart.yaml "version" value to the new version
alongside the existing appVersion change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: df984c28-5e21-4941-bff4-c79408eaa33a
📒 Files selected for processing (234)
CHANGELOG.mdVERSIONdocs/index.htmlhelm/charts/carbide-rest/Chart.yamlopenapi/spec.yamlsdk/standard/api_allocation.gosdk/standard/api_audit.gosdk/standard/api_dpu_extension_service.gosdk/standard/api_expected_machine.gosdk/standard/api_expected_power_shelf.gosdk/standard/api_expected_switch.gosdk/standard/api_infini_band_partition.gosdk/standard/api_infrastructure_provider.gosdk/standard/api_instance.gosdk/standard/api_instance_type.gosdk/standard/api_ip_block.gosdk/standard/api_machine.gosdk/standard/api_metadata.gosdk/standard/api_network_security_group.gosdk/standard/api_nv_link_logical_partition.gosdk/standard/api_operating_system.gosdk/standard/api_rack.gosdk/standard/api_service_account.gosdk/standard/api_site.gosdk/standard/api_sku.gosdk/standard/api_ssh_key.gosdk/standard/api_ssh_key_group.gosdk/standard/api_subnet.gosdk/standard/api_tenant.gosdk/standard/api_tenant_account.gosdk/standard/api_tray.gosdk/standard/api_user.gosdk/standard/api_vpc.gosdk/standard/api_vpc_peering.gosdk/standard/api_vpc_prefix.gosdk/standard/client.gosdk/standard/configuration.gosdk/standard/model_allocation.gosdk/standard/model_allocation_constraint.gosdk/standard/model_allocation_constraint_create_request.gosdk/standard/model_allocation_constraint_update_request.gosdk/standard/model_allocation_create_request.gosdk/standard/model_allocation_stats.gosdk/standard/model_allocation_status.gosdk/standard/model_allocation_update_request.gosdk/standard/model_audit_entry.gosdk/standard/model_batch_bring_up_rack_request.gosdk/standard/model_batch_instance_create_request.gosdk/standard/model_batch_rack_firmware_update_request.gosdk/standard/model_batch_tray_firmware_update_request.gosdk/standard/model_batch_update_rack_power_state_request.gosdk/standard/model_batch_update_tray_power_state_request.gosdk/standard/model_bmc_info.gosdk/standard/model_bring_up_rack_request.gosdk/standard/model_bring_up_rack_response.gosdk/standard/model_carbide_api_error.gosdk/standard/model_component_diff.gosdk/standard/model_deprecation.gosdk/standard/model_dpu_extension_service.gosdk/standard/model_dpu_extension_service_create_request.gosdk/standard/model_dpu_extension_service_credentials.gosdk/standard/model_dpu_extension_service_deployment.gosdk/standard/model_dpu_extension_service_deployment_request.gosdk/standard/model_dpu_extension_service_deployment_status.gosdk/standard/model_dpu_extension_service_observability.gosdk/standard/model_dpu_extension_service_observability_config.gosdk/standard/model_dpu_extension_service_observability_logging.gosdk/standard/model_dpu_extension_service_observability_prometheus.gosdk/standard/model_dpu_extension_service_status.gosdk/standard/model_dpu_extension_service_summary.gosdk/standard/model_dpu_extension_service_update_request.gosdk/standard/model_dpu_extension_service_version_info.gosdk/standard/model_expected_machine.gosdk/standard/model_expected_machine_create_request.gosdk/standard/model_expected_machine_update_request.gosdk/standard/model_expected_power_shelf.gosdk/standard/model_expected_power_shelf_create_request.gosdk/standard/model_expected_power_shelf_update_request.gosdk/standard/model_expected_switch.gosdk/standard/model_expected_switch_create_request.gosdk/standard/model_expected_switch_update_request.gosdk/standard/model_field_diff.gosdk/standard/model_firmware_update_request.gosdk/standard/model_firmware_update_response.gosdk/standard/model_infini_band_interface.gosdk/standard/model_infini_band_interface_create_request.gosdk/standard/model_infini_band_interface_status.gosdk/standard/model_infini_band_partition.gosdk/standard/model_infini_band_partition_create_request.gosdk/standard/model_infini_band_partition_status.gosdk/standard/model_infini_band_partition_update_request.gosdk/standard/model_infrastructure_provider.gosdk/standard/model_infrastructure_provider_stats.gosdk/standard/model_instance.gosdk/standard/model_instance_count_by_status.gosdk/standard/model_instance_create_request.gosdk/standard/model_instance_delete_request.gosdk/standard/model_instance_status.gosdk/standard/model_instance_type.gosdk/standard/model_instance_type_allocation_stats.gosdk/standard/model_instance_type_capability_create_request.gosdk/standard/model_instance_type_create_request.gosdk/standard/model_instance_type_stats.gosdk/standard/model_instance_type_status.gosdk/standard/model_instance_type_summary.gosdk/standard/model_instance_type_update_request.gosdk/standard/model_instance_update_request.gosdk/standard/model_interface.gosdk/standard/model_interface_create_request.gosdk/standard/model_interface_status.gosdk/standard/model_ip_block.gosdk/standard/model_ip_block_count_by_status.gosdk/standard/model_ip_block_create_request.gosdk/standard/model_ip_block_status.gosdk/standard/model_ip_block_summary.gosdk/standard/model_ip_block_update_request.gosdk/standard/model_ip_block_usage_stats.gosdk/standard/model_machine.gosdk/standard/model_machine_bmc_info.gosdk/standard/model_machine_capability.gosdk/standard/model_machine_count_by_status.gosdk/standard/model_machine_dmi_data.gosdk/standard/model_machine_gpu_info.gosdk/standard/model_machine_gpu_stats.gosdk/standard/model_machine_health.gosdk/standard/model_machine_health_issue.gosdk/standard/model_machine_health_probe_alert.gosdk/standard/model_machine_health_probe_success.gosdk/standard/model_machine_infini_band_interface.gosdk/standard/model_machine_instance_type.gosdk/standard/model_machine_instance_type_create_request.gosdk/standard/model_machine_instance_type_stats.gosdk/standard/model_machine_instance_type_summary.gosdk/standard/model_machine_interface.gosdk/standard/model_machine_metadata.gosdk/standard/model_machine_network_interface.gosdk/standard/model_machine_status.gosdk/standard/model_machine_status_breakdown.gosdk/standard/model_machine_summary.gosdk/standard/model_machine_update_request.gosdk/standard/model_metadata.gosdk/standard/model_network_security_group.gosdk/standard/model_network_security_group_create_request.gosdk/standard/model_network_security_group_propagation_details.gosdk/standard/model_network_security_group_propagation_status.gosdk/standard/model_network_security_group_rule.gosdk/standard/model_network_security_group_status.gosdk/standard/model_network_security_group_update_request.gosdk/standard/model_nv_link_interface.gosdk/standard/model_nv_link_interface_create_request.gosdk/standard/model_nv_link_interface_status.gosdk/standard/model_nv_link_logical_partition.gosdk/standard/model_nv_link_logical_partition_create_request.gosdk/standard/model_nv_link_logical_partition_status.gosdk/standard/model_nv_link_logical_partition_update_request.gosdk/standard/model_operating_system.gosdk/standard/model_operating_system_create_request.gosdk/standard/model_operating_system_site_association.gosdk/standard/model_operating_system_status.gosdk/standard/model_operating_system_update_request.gosdk/standard/model_rack.gosdk/standard/model_rack_component.gosdk/standard/model_rack_filter.gosdk/standard/model_rack_location.gosdk/standard/model_rack_task.gosdk/standard/model_rack_validation_result.gosdk/standard/model_service_account.gosdk/standard/model_site.gosdk/standard/model_site_capabilities.gosdk/standard/model_site_contact.gosdk/standard/model_site_create_request.gosdk/standard/model_site_location.gosdk/standard/model_site_machine_stats.gosdk/standard/model_site_machine_stats_by_allocation.gosdk/standard/model_site_machine_stats_by_health.gosdk/standard/model_site_machine_stats_by_status.gosdk/standard/model_site_machine_stats_by_status_and_health.gosdk/standard/model_site_status.gosdk/standard/model_site_summary.gosdk/standard/model_site_update_request.gosdk/standard/model_sku.gosdk/standard/model_sku_chassis.gosdk/standard/model_sku_components.gosdk/standard/model_sku_cpu.gosdk/standard/model_sku_ethernet_device.gosdk/standard/model_sku_gpu.gosdk/standard/model_sku_infiniband_device.gosdk/standard/model_sku_memory.gosdk/standard/model_sku_storage.gosdk/standard/model_sku_tpm.gosdk/standard/model_ssh_key.gosdk/standard/model_ssh_key_create_request.gosdk/standard/model_ssh_key_group.gosdk/standard/model_ssh_key_group_create_request.gosdk/standard/model_ssh_key_group_site_association.gosdk/standard/model_ssh_key_group_site_association_status.gosdk/standard/model_ssh_key_group_status.gosdk/standard/model_ssh_key_group_update_request.gosdk/standard/model_ssh_key_update_request.gosdk/standard/model_status_detail.gosdk/standard/model_subnet.gosdk/standard/model_subnet_count_by_status.gosdk/standard/model_subnet_create_request.gosdk/standard/model_subnet_status.gosdk/standard/model_subnet_update_request.gosdk/standard/model_tenant.gosdk/standard/model_tenant_account.gosdk/standard/model_tenant_account_count_by_status.gosdk/standard/model_tenant_account_create_request.gosdk/standard/model_tenant_account_status.gosdk/standard/model_tenant_capabilities.gosdk/standard/model_tenant_instance_type_stats.gosdk/standard/model_tenant_stats.gosdk/standard/model_tray.gosdk/standard/model_tray_filter.gosdk/standard/model_tray_position.gosdk/standard/model_update_power_state_request.gosdk/standard/model_update_power_state_response.gosdk/standard/model_user.gosdk/standard/model_vpc.gosdk/standard/model_vpc_count_by_status.gosdk/standard/model_vpc_create_request.gosdk/standard/model_vpc_peering.gosdk/standard/model_vpc_peering_create_request.gosdk/standard/model_vpc_peering_status.gosdk/standard/model_vpc_prefix.gosdk/standard/model_vpc_prefix_create_request.gosdk/standard/model_vpc_prefix_status.gosdk/standard/model_vpc_prefix_update_request.gosdk/standard/model_vpc_status.gosdk/standard/model_vpc_update_request.gosdk/standard/model_vpc_virtualization_update_request.gosdk/standard/response.gosdk/standard/utils.go
Comment on lines
5
to
+6
| version: 0.1.5 | ||
| appVersion: "1.2.1" | ||
| appVersion: "1.3.0" |
There was a problem hiding this comment.
Bump chart version when updating appVersion.
appVersion changed, but chart version did not. Helm package consumers rely on chart version increments to detect and pull chart updates, so this should be bumped in the same change.
Proposed fix
-version: 0.1.5
+version: 0.1.6
appVersion: "1.3.0"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| version: 0.1.5 | |
| appVersion: "1.2.1" | |
| appVersion: "1.3.0" | |
| version: 0.1.6 | |
| appVersion: "1.3.0" |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@helm/charts/carbide-rest/Chart.yaml` around lines 5 - 6, The Chart.yaml was
updated to change appVersion to "1.3.0" but the chart version was not
incremented; update the Chart.yaml "version" field to a new semantically
appropriate chart version (e.g., increment patch from 0.1.5 to 0.1.6 or follow
your chart versioning scheme) so that consumers can detect the chart update—edit
the Chart.yaml "version" value to the new version alongside the existing
appVersion change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Regular cadence release.
Type of Change
Services Affected
None
Related Issues (Optional)
None
Breaking Changes
Testing
Additional Notes
None