Skip to content

fix: Check power status DB attribute when filtering Instances by status#70

Draft
nvlitagaki wants to merge 2 commits intomainfrom
fix/instance-status-filter
Draft

fix: Check power status DB attribute when filtering Instances by status#70
nvlitagaki wants to merge 2 commits intomainfrom
fix/instance-status-filter

Conversation

@nvlitagaki
Copy link
Copy Markdown
Contributor

@nvlitagaki nvlitagaki commented Jan 27, 2026

  • Currently Instance status attribute in API layer presents both status and power status. However when filtering at DB layer we only check against DB status attribute
  • This change checks both status and power status DB attribute to return a better set of matches aligning with API values

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Jan 27, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@nvlitagaki nvlitagaki force-pushed the fix/instance-status-filter branch from eadfc12 to bb05eb4 Compare January 27, 2026 18:38
@github-actions

This comment was marked as outdated.

@nvlitagaki
Copy link
Copy Markdown
Contributor Author

@nvlitagaki nvlitagaki force-pushed the fix/instance-status-filter branch from bb05eb4 to a3f7cb8 Compare January 27, 2026 18:49
@thossain-nv thossain-nv changed the title fix: instance filtering on power status fix: Check power status DB attribute when filtering Instances by status Jan 27, 2026
Copy link
Copy Markdown
Contributor

@thossain-nv thossain-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @nvlitagaki

@thossain-nv
Copy link
Copy Markdown
Contributor

@nvlitagaki Seems like we have a few test failures.

@github-actions
Copy link
Copy Markdown

🔐 TruffleHog Secret Scan

No secrets or credentials found!

Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉

🔗 View scan details

🕐 Last updated: 2026-02-12 17:25:35 UTC | Commit: a813f77

@github-actions
Copy link
Copy Markdown

🛡️ Vulnerability Scan

🚨 Found 52 vulnerability(ies)

Severity Breakdown:

  • 🔴 Critical/High: 52
  • 🟡 Medium: 0
  • 🔵 Low/Info: 0
📋 Top Vulnerabilities
  • AVD-KSV-0109: Artifact: deploy/kustomize/base/api/configmap.yaml
    Type: kubernetes
    Vulnerability AVD-KSV-0109
    Severity: HIGH
    Message: ConfigMap 'carbide-rest-api-config' in 'default' namespace stores secrets in key(s) or value(s) '{" password"}'
    Link: AVD-KSV-0109 (deploy/kustomize/base/api/configmap.yaml)
  • KSV014: Artifact: deploy/kustomize/base/api/deployment.yaml
    Type: kubernetes
    Vulnerability KSV014
    Severity: HIGH
    Message: Container 'api' of Deployment 'carbide-rest-api' should set 'securityContext.readOnlyRootFilesystem' to true
    Link: KSV014 (deploy/kustomize/base/api/deployment.yaml)
  • KSV118: Artifact: deploy/kustomize/base/api/deployment.yaml
    Type: kubernetes
    Vulnerability KSV118
    Severity: HIGH
    Message: container carbide-rest-api in default namespace is using the default security context
    Link: KSV118 (deploy/kustomize/base/api/deployment.yaml)
  • KSV118: Artifact: deploy/kustomize/base/api/deployment.yaml
    Type: kubernetes
    Vulnerability KSV118
    Severity: HIGH
    Message: deployment carbide-rest-api in default namespace is using the default security context, which allows root privileges
    Link: KSV118 (deploy/kustomize/base/api/deployment.yaml)
  • KSV014: Artifact: deploy/kustomize/base/db-migrations/job.yaml
    Type: kubernetes
    Vulnerability KSV014
    Severity: HIGH
    Message: Container 'migrations' of Job 'db-migrations' should set 'securityContext.readOnlyRootFilesystem' to true
    Link: KSV014 (deploy/kustomize/base/db-migrations/job.yaml)
  • KSV014: Artifact: deploy/kustomize/base/db-migrations/job.yaml
    Type: kubernetes
    Vulnerability KSV014
    Severity: HIGH
    Message: Container 'wait-for-postgres' of Job 'db-migrations' should set 'securityContext.readOnlyRootFilesystem' to true
    Link: KSV014 (deploy/kustomize/base/db-migrations/job.yaml)
  • KSV118: Artifact: deploy/kustomize/base/db-migrations/job.yaml
    Type: kubernetes
    Vulnerability KSV118
    Severity: HIGH
    Message: container db-migrations in default namespace is using the default security context
    Link: KSV118 (deploy/kustomize/base/db-migrations/job.yaml)
  • KSV118: Artifact: deploy/kustomize/base/db-migrations/job.yaml
    Type: kubernetes
    Vulnerability KSV118
    Severity: HIGH
    Message: container db-migrations in default namespace is using the default security context
    Link: KSV118 (deploy/kustomize/base/db-migrations/job.yaml)
  • KSV118: Artifact: deploy/kustomize/base/db-migrations/job.yaml
    Type: kubernetes
    Vulnerability KSV118
    Severity: HIGH
    Message: job db-migrations in default namespace is using the default security context, which allows root privileges
    Link: KSV118 (deploy/kustomize/base/db-migrations/job.yaml)
  • KSV014: Artifact: deploy/kustomize/base/elektraserver/deployment.yaml
    Type: kubernetes
    Vulnerability KSV014
    Severity: HIGH
    Message: Container 'elektraserver' of Deployment 'carbide-rest-elektraserver' should set 'securityContext.readOnlyRootFilesystem' to true
    Link: KSV014 (deploy/kustomize/base/elektraserver/deployment.yaml)

💡 Note: Enable GitHub Advanced Security to see full details in the Security tab.

🕐 Last updated: 2026-02-12 17:25:39 UTC | Commit: a813f77

@NVIDIA NVIDIA deleted a comment from github-actions bot Feb 12, 2026
@NVIDIA NVIDIA deleted a comment from github-actions bot Feb 12, 2026
@NVIDIA NVIDIA deleted a comment from github-actions bot Feb 12, 2026
@NVIDIA NVIDIA deleted a comment from github-actions bot Feb 12, 2026
@NVIDIA NVIDIA deleted a comment from github-actions bot Feb 12, 2026
@NVIDIA NVIDIA deleted a comment from github-actions bot Feb 12, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 12, 2026

Test Results

6 460 tests  ±0   6 456 ✅  - 4   8m 1s ⏱️ +3s
   91 suites +1       0 💤 ±0 
   11 files   ±0       4 ❌ +4 

For more details on these failures, see this check.

Results for commit 788ca1a. ± Comparison against base commit fc25959.

♻️ This comment has been updated with latest results.

@nvlitagaki nvlitagaki force-pushed the fix/instance-status-filter branch from 6c808e8 to 5313353 Compare February 12, 2026 18:54
@nvlitagaki nvlitagaki force-pushed the fix/instance-status-filter branch from 5313353 to 788ca1a Compare February 12, 2026 19:39
@nvlitagaki nvlitagaki marked this pull request as draft February 18, 2026 17:46
@github-actions
Copy link
Copy Markdown

This PR has been inactive for 30 days and will be closed soon.
Please push commits or comment to keep it open.

@nvlitagaki
Copy link
Copy Markdown
Contributor Author

will get to this eventually -- just not a priority at present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants