fix: Reuse instantiated editsFactory in CDI#1666
Merged
elezar merged 1 commit intoNVIDIA:mainfrom Mar 5, 2026
Merged
Conversation
Pull Request Test Coverage Report for Build 22669179856Details
💛 - Coveralls |
elezar
changed the title
elezar
force-pushed
the
ensure-that-edit-factory-is-propagated
branch
from
7b7800d to
b464149
Compare
elezar
force-pushed
the
ensure-that-edit-factory-is-propagated
branch
2 times, most recently
from
f2add99 to
f9abeec
Compare
cdesiniotis
approved these changes
Mar 4, 2026
This change ensures that the editsFactory is instantiated once and passed to the nvcdi constructor. This makes it unnecessary to reprocess optional arguments and configs. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
ensure-that-edit-factory-is-propagated
branch
from
f9abeec to
79477c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that the editsFactory is instantiated
once and passed to the nvcdi constructor. This makes it
unnecessary to reprocess optional arguments and configs.