Use automatic CDI spec generation to generate CDI specs for other modifiers#1667
Merged
elezar merged 5 commits intoNVIDIA:mainfrom Mar 4, 2026
Merged
Use automatic CDI spec generation to generate CDI specs for other modifiers#1667elezar merged 5 commits intoNVIDIA:mainfrom
elezar merged 5 commits intoNVIDIA:mainfrom
Conversation
elezar
changed the title
elezar
force-pushed
the
unify-csv-and-jit-cdi
branch
from
712aaa2 to
6f8fed6
Compare
elezar
force-pushed
the
unify-csv-and-jit-cdi
branch
2 times, most recently
from
78d9067 to
4276f96
Compare
cdesiniotis
approved these changes
Mar 3, 2026
internal/modifier/factory.go
Outdated
|
|
||
| func (f *Factory) validate() error { | ||
| if f.driver == nil { | ||
| return fmt.Errorf("a driver muse be specified") |
Contributor
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("a driver muse be specified") | |
| return fmt.Errorf("a driver must be specified") |
This allows for other parts of the code to detect whether we're running in testing. Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
unify-csv-and-jit-cdi
branch
from
4276f96 to
af7b79b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that we reuse the instatiation of the nvcdi library to generate CDI specs for CSV mode, feature gated modes mode, as well as jit-cdi mode. This reduces the amount of code that needs to be kept in sync when making modifications.