Skip to content

fix: Don't use driver version in ELF header for compat check#1697

Merged
elezar merged 1 commit intoNVIDIA:mainfrom
elezar:fix-cuda-compat-check
Mar 5, 2026
Merged

fix: Don't use driver version in ELF header for compat check#1697
elezar merged 1 commit intoNVIDIA:mainfrom
elezar:fix-cuda-compat-check

Conversation

@elezar
Copy link
Member

@elezar elezar commented Mar 5, 2026

This change reverts the inspection of the libcuda.so ELF header on non-Tegra systems. The expectations around this need to be better defined as certain host-container version combinations (e.g. Host: 580.126.16, Container: 580.82.07) causes simple examples to fail if the container version is used.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 22712874358

Details

  • 6 of 14 (42.86%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 43.34%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/nvidia-cdi-hook/cudacompat/cuda-elf-header.go 0 1 0.0%
cmd/nvidia-cdi-hook/cudacompat/cudacompat.go 6 13 46.15%
Files with Coverage Reduction New Missed Lines %
cmd/nvidia-cdi-hook/cudacompat/cuda-elf-header.go 2 55.22%
Totals Coverage Status
Change from base Build 22668622243: -0.006%
Covered Lines: 6423
Relevant Lines: 14820

💛 - Coveralls

@elezar elezar added the bug Issue/PR to expose/discuss/fix a bug label Mar 5, 2026
@elezar elezar added this to the v1.19.0 milestone Mar 5, 2026
@elezar elezar merged commit 08bf583 into NVIDIA:main Mar 5, 2026
16 checks passed
@elezar elezar deleted the fix-cuda-compat-check branch March 5, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue/PR to expose/discuss/fix a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants