Open
Conversation
When building with NVHPC, CMake is not configured for CUDA. The fact that newly added test when_all_fail was set up with "LANGUAGE CUDA" was causing CMake failures when the compiler was NVHPC. To fix this, put the definition of test when_all_fail inside an if(NOT (CMAKE_CXX_COMPILER_ID STREQUAL "NVHPC")) block.
Collaborator
|
but why? nvc++ is passing this test in CI. i took special care to make it so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building with NVHPC, CMake is not configured for CUDA. The fact that newly added test when_all_fail was set up with "LANGUAGE CUDA" was causing CMake failures when the compiler was NVHPC.
To fix this, put the definition of test when_all_fail inside an
block.