Skip to content

Forward rooted environment in start_detached - #2162

Open
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/start-detached-root-env
Open

Forward rooted environment in start_detached#2162
fallintoplace wants to merge 1 commit into
NVIDIA:mainfrom
fallintoplace:fix/start-detached-root-env

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

Summary

  • forward the rooted environment into apply_sender
  • add coverage for a move-only environment

Why

The two-argument overload stores the rooted environment in __env2 and then passes that named variable as an lvalue. The default implementation stores the decayed environment by value, so a move-only environment cannot be used. Forwarding __env2 keeps the value category expected by the constraints.

Testing

  • cmake --build build --target test.exec -j 8
  • ./build/test/exec/test.exec '[start_detached]'

@copy-pr-bot

copy-pr-bot Bot commented Aug 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@fallintoplace
fallintoplace marked this pull request as ready for review August 8, 2026 15:33
@ericniebler

Copy link
Copy Markdown
Collaborator

/ok to test 7e930c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants