Forward rooted environment in start_detached - #2162
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
fallintoplace
marked this pull request as ready for review
August 8, 2026 15:33
ericniebler
approved these changes
Aug 9, 2026
Collaborator
|
/ok to test 7e930c2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply_senderWhy
The two-argument overload stores the rooted environment in
__env2and then passes that named variable as an lvalue. The default implementation stores the decayed environment by value, so a move-only environment cannot be used. Forwarding__env2keeps the value category expected by the constraints.Testing
cmake --build build --target test.exec -j 8./build/test/exec/test.exec '[start_detached]'