Preserve completion scheduler in timed fallbacks - #2164
Open
fallintoplace wants to merge 3 commits into
Open
Conversation
ericniebler
reviewed
Aug 9, 2026
|
|
||
| #include <chrono> | ||
|
|
||
| namespace STDEXEC::__timed_scheduler_fallback |
Collaborator
There was a problem hiding this comment.
should this be in namespace experimental::execution instead of STDEXEC?
Collaborator
|
/ok to test 10db6f0 |
fallintoplace
marked this pull request as ready for review
August 9, 2026 13:23
Collaborator
|
/ok to test 70dddb5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The timed scheduler fallbacks currently use
let_value(just(), ...)to keepnow()lazy.let_valuedoes not expose a completion scheduler, so both fallback senders loseget_completion_scheduler<set_value_t>even when the delegated timed sender advertises it.This adds a small internal wrapper that forwards the fallback sender’s existing completion behavior and signatures and adds the set-value completion scheduler. Tests cover both fallback directions.
Testing
build/test/exec/test.execbuild/test/exec/test.exec "[timed_scheduler]"build/test/exec/test.exec "[timed_thread_scheduler]"