chore(release): prepare v1.0.0-rc.2 - #455
Conversation
Signed-off-by: Dmitry Shmulevich <17212177+dmitsh@users.noreply.github.com>
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Helm chart and application versions were updated from ChangesHelm release version update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryPrepares the Helm chart for the v1.0.0-rc.2 release.
Confidence Score: 5/5The release metadata update appears safe to merge. The chart and application versions advance consistently, while existing chart tests deliberately isolate snapshots from release-version changes and no blocking version-alignment failure remains. Important Files Changed
Reviews (1): Last reviewed commit: "chore(release): prepare v1.0.0-rc.2" | Re-trigger Greptile |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/topograph/Chart.yaml`:
- Around line 6-7: Publish the release container image
ghcr.io/nvidia/topograph:v1.0.0-rc.2 before running the Helm chart release for
version 1.0.0-rc.2. Coordinate the independent Docker and Helm release workflows
so the image is available before the chart is deployed with the default
image.tag configuration.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: 811dcf1b-c5d2-4853-8bfe-ceb47f4f8da6
📒 Files selected for processing (1)
charts/topograph/Chart.yaml
📜 Review details
⏰ Context from checks skipped due to timeout. (2)
- GitHub Check: govulncheck
- GitHub Check: Greptile Review
🧰 Additional context used
📓 Path-based instructions (3)
charts/topograph/**/*.yaml
📄 CodeRabbit inference engine (AGENTS.md)
Do not enable both
ingress.enabledandgatewayAPI.enabledin one Helm release; the routing resources are mutually exclusive.
Files:
charts/topograph/Chart.yaml
**/*
📄 CodeRabbit inference engine (AGENTS.md)
**/*: Do not publicly disclose suspected security vulnerabilities; report them privately through NVIDIA PSIRT using the channels documented inSECURITY.md.
Every commit must include aSigned-off-by:trailer for DCO compliance.
Use Conventional Commits with an allowed type such asfeat,fix,docs,chore,refactor,test,build, orci.
Before pushing, runmake qualify; all CI checks, including Go build/test/lint, Codecov, and DCO, must be green before merge.
Changes to provider, engine, chart, API, configuration schema, labels, annotations, or user-facing behavior must include the corresponding documentation updates described in the documentation impact table.
Files:
charts/topograph/Chart.yaml
charts/topograph/**
⚙️ CodeRabbit configuration file
charts/topograph/**: - Check RBAC least privilege and Kubernetes API compatibility.
- ingress.enabled and gatewayAPI.enabled must remain mutually exclusive.
- HTTPRoute must contain only portable Gateway API v1 fields.
- Flag changes where values, schema, templates, NOTES, tests,
snapshots, documentation, or changelog become inconsistent.
Files:
charts/topograph/Chart.yaml
| version: "1.0.0-rc.2" | ||
| appVersion: "v1.0.0-rc.2" |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
tag="v1.0.0-rc.2"
rg -n -C 4 'appVersion|image.tag|ghcr.io/nvidia/topograph' \
charts/topograph/Chart.yaml \
charts/topograph/tests/deployment_test.yaml || true
rg -n -C 6 'build-push|docker.*push|ghcr.io/nvidia/topograph|v1.0.0-rc.2' \
.github/workflows || true
token="$(curl -fsSL \
'https://ghcr.io/token?service=ghcr.io&scope=repository:nvidia/topograph:pull' |
jq -r '.token')"
test -n "$token" && test "$token" != "null"
curl -fsSI \
-H "Authorization: Bearer ${token}" \
-H 'Accept: application/vnd.oci.image.manifest.v1+json' \
"https://ghcr.io/v2/nvidia/topograph/manifests/${tag}" >/dev/nullRepository: NVIDIA/topograph
Length of output: 4496
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
printf '%s\n' '--- Docker workflow ---'
cat -n .github/workflows/docker.yml | sed -n '1,110p'
printf '%s\n' '--- Helm release workflow ---'
cat -n .github/workflows/helm-release.yaml | sed -n '1,100p'
printf '%s\n' '--- Chart image defaults and template ---'
rg -n -C 5 'repository:|tag:|appVersion|image:' charts/topograph/values.yaml charts/topograph/templates/deployment.yaml charts/topograph/Chart.yaml
printf '%s\n' '--- Image tag references ---'
rg -n -C 3 'v1\.0\.0-rc\.2|docker/metadata|type=semver|tags:' .github/workflows charts/topographRepository: NVIDIA/topograph
Length of output: 10649
Publish the release image before the chart.
The Docker and Helm release workflows are independent manual workflows. Publish ghcr.io/nvidia/topograph:v1.0.0-rc.2 before releasing the chart. With the default image.tag: "", a missing image causes ImagePullBackOff.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@charts/topograph/Chart.yaml` around lines 6 - 7, Publish the release
container image ghcr.io/nvidia/topograph:v1.0.0-rc.2 before running the Helm
chart release for version 1.0.0-rc.2. Coordinate the independent Docker and Helm
release workflows so the image is available before the chart is deployed with
the default image.tag configuration.
1 participant
No description provided.