chore(release): prepare v1.0.0-rc.3 (NO NEED TO MERGE) - #463
Conversation
Signed-off-by: Dmitry Shmulevich <17212177+dmitsh@users.noreply.github.com>
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Helm chart and application versions change from ChangesChart release metadata
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryUpdates the Helm chart metadata in preparation for the v1.0.0-rc.3 release.
Confidence Score: 5/5The metadata-only release preparation appears safe to merge, with no concrete defects identified. The chart and application versions are advanced consistently, and the available repository evidence does not establish a broken packaging, rendering, or deployment contract. Important Files Changed
Reviews (1): Last reviewed commit: "chore(release): prepare v1.0.0-rc.3" | Re-trigger Greptile |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/topograph/Chart.yaml`:
- Around line 6-7: Update the documentation associated with the Topograph chart
to reflect the release metadata changes in Chart.yaml, following the required
documentation impact table. Make the documentation update within the supplied
chart scope and ensure it is included before merge.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: db9ac8cb-83d5-4d14-be10-27fd20cc4a92
📒 Files selected for processing (1)
charts/topograph/Chart.yaml
📜 Review details
🧰 Additional context used
📓 Path-based instructions (3)
charts/topograph/**/*.yaml
📄 CodeRabbit inference engine (AGENTS.md)
Do not enable both
ingress.enabledandgatewayAPI.enabledin one Helm release; the routing resources are mutually exclusive.
Files:
charts/topograph/Chart.yaml
**/*
📄 CodeRabbit inference engine (AGENTS.md)
**/*: Do not publicly disclose suspected security vulnerabilities; report them privately through NVIDIA PSIRT using the channels documented inSECURITY.md.
Every commit must include aSigned-off-by:trailer for DCO compliance.
Use Conventional Commits with an allowed type such asfeat,fix,docs,chore,refactor,test,build, orci.
Before pushing, runmake qualify; all CI checks, including Go build/test/lint, Codecov, and DCO, must be green before merge.
Changes to provider, engine, chart, API, configuration schema, labels, annotations, or user-facing behavior must include the corresponding documentation updates described in the documentation impact table.
Files:
charts/topograph/Chart.yaml
charts/topograph/**
⚙️ CodeRabbit configuration file
charts/topograph/**: - Check RBAC least privilege and Kubernetes API compatibility.
- ingress.enabled and gatewayAPI.enabled must remain mutually exclusive.
- HTTPRoute must contain only portable Gateway API v1 fields.
- Flag changes where values, schema, templates, NOTES, tests,
snapshots, documentation, or changelog become inconsistent.
Files:
charts/topograph/Chart.yaml
🧠 Learnings (5)
📚 Learning: 2026-08-08T10:57:01.397Z
Learnt from: CR
Repo: NVIDIA/topograph PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-08-08T10:57:01.397Z
Learning: Applies to charts/topograph/tests/**/*.{yaml,yml} : Run Helm chart tests when changing `charts/topograph/`; review snapshot changes before committing updates.
Applied to files:
charts/topograph/Chart.yaml
📚 Learning: 2026-08-08T10:57:01.397Z
Learnt from: CR
Repo: NVIDIA/topograph PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-08-08T10:57:01.397Z
Learning: Applies to **/* : Changes to provider, engine, chart, API, configuration schema, labels, annotations, or user-facing behavior must include the corresponding documentation updates described in the documentation impact table.
Applied to files:
charts/topograph/Chart.yaml
📚 Learning: 2026-08-08T10:57:01.397Z
Learnt from: CR
Repo: NVIDIA/topograph PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-08-08T10:57:01.397Z
Learning: Applies to CHANGELOG.md : Record applicable user-facing features, fixes, breaking changes, or Helm migrations under `[Unreleased]`.
Applied to files:
charts/topograph/Chart.yaml
📚 Learning: 2026-08-08T10:57:01.397Z
Learnt from: CR
Repo: NVIDIA/topograph PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-08-08T10:57:01.397Z
Learning: Applies to pkg/providers/**/*.go : Providers discover topology and return the canonical `topology.Graph`; they must not emit scheduler-specific output.
Applied to files:
charts/topograph/Chart.yaml
📚 Learning: 2026-08-08T10:57:01.397Z
Learnt from: CR
Repo: NVIDIA/topograph PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-08-08T10:57:01.397Z
Learning: Applies to pkg/providers/**/*.go : When using `ClusterTopology`, populate fabric tiers closest-first, preserve optional accelerator domain and sub-domain fields, and call `ToGraph`.
Applied to files:
charts/topograph/Chart.yaml
🔇 Additional comments (1)
charts/topograph/Chart.yaml (1)
6-7: 🎯 Functional CorrectnessRun the chart validation and qualification checks before merge.
Run
make chart-testandmake qualify. Confirm that Helm lint, Helm unit tests, and all CI checks pass.Based on learnings, changes under
charts/topograph/require Helm chart tests. As per coding guidelines, runmake qualifyand require all CI checks to pass before merge.Sources: Coding guidelines, Learnings
| version: "1.0.0-rc.3" | ||
| appVersion: "v1.0.0-rc.3" |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add the required chart documentation update.
Lines 6-7 change the chart release metadata. The supplied cohort contains only charts/topograph/Chart.yaml. Add the documentation update required by the documentation impact table before merge.
As per coding guidelines, chart changes must include the corresponding documentation updates described in the documentation impact table.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@charts/topograph/Chart.yaml` around lines 6 - 7, Update the documentation
associated with the Topograph chart to reflect the release metadata changes in
Chart.yaml, following the required documentation impact table. Make the
documentation update within the supplied chart scope and ensure it is included
before merge.
Source: Coding guidelines
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
==========================================
+ Coverage 72.15% 77.12% +4.96%
==========================================
Files 89 99 +10
Lines 5689 7200 +1511
==========================================
+ Hits 4105 5553 +1448
+ Misses 1382 1358 -24
- Partials 202 289 +87 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
1 participant
No description provided.