Replace arbitrary sequence length kernel wrapper with a padding wrapper.#14
Merged
maximilianmbeck merged 4 commits intomainfrom Mar 1, 2026
Merged
Replace arbitrary sequence length kernel wrapper with a padding wrapper.#14maximilianmbeck merged 4 commits intomainfrom
maximilianmbeck merged 4 commits intomainfrom
Conversation
…e. Now we pad with the proper values to maintain the memory cell state.
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Collaborator
Author
|
I have read the CLA Document and I hereby sign the CLA |
Collaborator
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the default
wrap_chunkwise__arbitrary_sequence_lengthkernel wrapper for inference (more precisely for prefill with thewrap_chunkwise__arbitrary_sequence_length_with_paddingkernel wrapper.We keep the old wrapper functions for reference.
In short, the new wrapper relies on the insight that we can pad the qkv sequence from the right with zeros and set the forget gate to 1 and the input gate to 0, so that the final memory state is maintained over the padding time steps.
This is more efficient than the previous arbitrary sequence length kernel wrapper, which relied on a sequence of chunkwise and step kernel calls to precisely match the arbitrary sequence length.