Set "from" email address using settings table instead of hard-coding

app/mailers/admin_mailer.rb

@@ -1,6 +1,4 @@
 class AdminMailer < ActionMailer::Base
-  default :from => "nztrain@gmail.com"
-
   def custom_email(admin,user,subject,msgbody)
     @user = user
     @msgbody = msgbody

app/views/user/admin_email.html.erb

@@ -13,7 +13,7 @@
   </div>
   <p>
     <%= current_user.name %><br />
-    Admin of nztrain.com
+    Admin of NZOI Training
   </p>
 
   <div class="actions">

config/application.rb

@@ -2,7 +2,7 @@
 require 'rubygems'
 require 'rails/all'
 
-if defined?(Bundler)  
+if defined?(Bundler)
   # Require the gems listed in Gemfile, including any gems
   # you've limited to :test, :development, or :production.
   Bundler.require(:default, Rails.env)
@@ -46,15 +46,14 @@ class Application < Rails::Application
     config.action_mailer.delivery_method = :smtp
     config.action_mailer.perform_deliveries = true
     config.action_mailer.raise_delivery_errors = true
-    config.action_mailer.default :charset => "utf-8"
 
     ActionMailer::Base.smtp_settings = {
       :address => "smtp.gmail.com",
       :port => 587,
       :authentication => :plain,
-      :domain => 'nztrain.com',
-      :user_name => 'nztrain@gmail.com', # username and password set with higher priority in settings table
-      :password => 'training site',
+      :domain => 'nzoi.org.nz',
+      #:user_name => ..., # set in config/initializers/mailer.rb
+      #:password => ...,  # set in config/initializers/mailer.rb
       :enable_starttls_auto => true
     }
 

config/environments/test.rb

@@ -25,6 +25,8 @@
   # ActionMailer::Base.deliveries array.
   config.action_mailer.delivery_method = :test
 
+  config.action_mailer.default_options = { from: "train@example.com" }
+
   # Use SQL instead of Active Record's schema dumper when creating the test database.
   # This is necessary if your schema can't be completely dumped by the schema dumper,
   # like if you have constraints or database-specific column types

config/initializers/devise.rb

@@ -10,7 +10,7 @@
   # Configure the e-mail address which will be shown in Devise::Mailer,
   # note that it will be overwritten if you use your own mailer class
   # with default "from" parameter.
-  config.mailer_sender = "nztrain@gmail.com"
+  #config.mailer_sender = ...
 
   # Configure the class responsible to send e-mails.
   # config.mailer = "Devise::Mailer"

config/initializers/mailer.rb

@@ -1,7 +1,17 @@
-# use db stored username and password for email if present
+# use db-stored email address and password for sending email
+
+def email_address_with_name(address, name)
+  # can switch to ActionMailer::Base.email_address_with_name() once we upgrade to Rails 6
+  Mail::Address.new.tap do |builder|
+    builder.address = address
+    builder.display_name = name.presence
+  end.to_s
+end
 
 if ActiveRecord::Base.connection.table_exists?(Setting.table_name)
-  ActionMailer::Base.smtp_settings[:user_name] = Setting.find_by_key("system/mailer/username").value if Setting.find_by_key("system/mailer/username")
-  ActionMailer::Base.smtp_settings[:password] = Setting.find_by_key("system/mailer/password").value if Setting.find_by_key("system/mailer/password")
+  email_setting = Setting.find_by_key("system/mailer/email")
+  ActionMailer::Base.smtp_settings[:user_name] = email_setting&.value
+  ActionMailer::Base.smtp_settings[:password] = Setting.find_by_key("system/mailer/password")&.value
+  ActionMailer::Base.default from: email_address_with_name(email_setting.value, "NZOI Training") if email_setting&.value.present?
 end
 

db/migrate/20250318053450_rename_setting_mailer_username_to_email.rb

@@ -0,0 +1,11 @@
+class RenameSettingMailerUsernameToEmail < ActiveRecord::Migration
+  # this migration can be deleted after deploying
+
+  def up
+    execute "UPDATE settings SET key = 'system/mailer/email' WHERE key = 'system/mailer/username'"
+  end
+
+  def down
+    execute "UPDATE settings SET key = 'system/mailer/username' WHERE key = 'system/mailer/email'"
+  end
+end

db/schema.rb

@@ -11,7 +11,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20230225054132) do
+ActiveRecord::Schema.define(version: 20250318053450) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"

db/seeds.rb

@@ -34,7 +34,7 @@
   superadmin.users.push(rootuser) unless superadmin.users.include?(rootuser);
 end
 
-["recaptcha/public_key","recaptcha/private_key"].each do |setting|
+["system/mailer/email","system/mailer/password","recaptcha/public_key","recaptcha/private_key"].each do |setting|
   Setting.find_or_create_by(key: setting)
 end
 

lib/development_mail_interceptor.rb

@@ -1,7 +1,7 @@
 class DevelopmentMailInterceptor
   def self.delivering_email(message)
     message.subject = "[Development] #{message.to} #{message.subject}"
-    message.to = "nztrain@gmail.com"
+    message.to = message.from
   end
 end