Skip to content
This repository was archived by the owner on Aug 5, 2024. It is now read-only.

Update title on new windows#4

Open
Eggrror404 wants to merge 1 commit into
Naezr:mainfrom
Eggrror404:main
Open

Update title on new windows#4
Eggrror404 wants to merge 1 commit into
Naezr:mainfrom
Eggrror404:main

Conversation

@Eggrror404

Copy link
Copy Markdown

Currently the extension does not update the title on new windows after initialization completed, leading to a weird behavior - the toggles are not applied until one got changed. That means when you open a new window, you'd have to toggle off then on again for the original setting to remain.

This PR fixes it by calling updateTitlePrefixes on every window opened so settings will be applied.

@Naezr

Naezr commented Jul 29, 2024

Copy link
Copy Markdown
Owner

https://github.com/Naezr/userchrome-toggle-extended-2

I'm rewriting this extension from scratch. My version doesn't have this problem

When I finish this, I'll upload the new version as an update to the old one. This repo will be archived later, since it's a fork. I wrote the new version myself, so it's in the new repository

@Eggrror404

Copy link
Copy Markdown
Author

https://github.com/Naezr/userchrome-toggle-extended-2

I'm rewriting this extension from scratch. My version doesn't have this problem

When I finish this, I'll upload the new version as an update to the old one. This repo will be archived later, since it's a fork. I wrote the new version myself, so it's in the new repository

Glad to know that :) I did this patch just because I was a bit annoyed by the issue 😅
Looking forward to the new version!

Also the firefox userchrome you created has been a great experience, thank you for that as well!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants