feat(desktop): sync terminal chrome with the app theme - #1097
Open
RaspberryLee wants to merge 1 commit into
Open
feat(desktop): sync terminal chrome with the app theme#1097RaspberryLee wants to merge 1 commit into
RaspberryLee wants to merge 1 commit into
Conversation
PR quality triageChanged areas: area:desktop CLI core policy: No CLI-core policy block detected. Missing-test policy: No missing-test policy block detected. Coverage baseline policy: No coverage-baseline policy block detected. CLI core files:
Coverage policy files:
Required check plan:
Test coverage signals:
Risk notes:
Hard merge gates come from the deterministic GitHub Actions contract lanes above. |
RaspberryLee
marked this pull request as ready for review
July 23, 2026 09:55
RaspberryLee
force-pushed
the
feat/terminal-toolbar-theme-sync
branch
2 times, most recently
from
July 27, 2026 08:05
57f6890 to
68b3da1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the integrated terminal chrome with the desktop application theme.
This removes the decorative macOS traffic-light dots from the terminal toolbar, replaces text-heavy actions with accessible icon controls, and keeps xterm colors synchronized with the active light or dark application theme. The terminal process and PTY behavior are unchanged.
Feature Quality Contract
desktop/src/pages/TerminalSettings.test.tsxcd desktop && bun run test -- --run src/pages/TerminalSettings.test.tsx— 18 passed, 0 failedbun run check:impactselectedcheck:desktopandcheck:coverage.cd desktop && bun run build.check:desktoplint passed, then the suite reported 2,092 passed, 364 failed, 2 skipped. Failures are dominated by the current Node 26 environment exposinglocalStorageas unavailable, Windows symlinkEPERM, and existing Mermaid/test timeouts.artifacts/coverage/2026-07-23T08-59-37-631Z/coverage-report.md; desktop instrumentation failed in the same environment, so changed-line coverage was unavailable locally.Verification
bun run check:impact; environmental blockers are documented above.Risk