DBZ-1423 The internal option snapshot.scan.all.columns.force should be defined with database prefix [DBZ-9619]#16
Open
naros-ai-agent[bot] wants to merge 2 commits into
Open
DBZ-1423 The internal option snapshot.scan.all.columns.force should be defined with database prefix [DBZ-9619]#16naros-ai-agent[bot] wants to merge 2 commits into
naros-ai-agent[bot] wants to merge 2 commits into
Conversation
…Configuration subset merging Generated by AI agent in response to debezium/dbz#1423. Signed-off-by: Chris Cranford <chris@hibernate.org>
Naros
requested changes
May 13, 2026
…ORCE
Added `.withDeprecatedAliases("internal.snapshot.scan.all.columns.force")` to the `SNAPSHOT_FULL_COLUMN_SCAN_FORCE` field definition in `RelationalDatabaseConnectorConfig.java`, as requested by the reviewer. The alias uses the full old field name including the `internal.` prefix, since `Field.withDeprecatedAliases()` stores aliases as literal strings without auto-prefixing.
Generated by AI agent in response to debezium/dbz#1423.
Signed-off-by: Chris Cranford <chris@hibernate.org>
Author
|
🤖 Agent re-ran in response to review feedback. New commit(s) pushed to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue DBZ-1423
Description
Adds
internal.database.andinternal.driver.prefix support toJdbcConfigurationconstruction so that internal properties likeSNAPSHOT_FULL_COLUMN_SCAN_FORCEcan be defined with adatabase.namespace prefix, making their relationship to the JDBC configuration self-documenting.ConfigurationNames(debezium-config): AddedINTERNAL_DATABASE_CONFIG_PREFIX("internal.database.") andINTERNAL_DRIVER_CONFIG_PREFIX("internal.driver.") constants, composed fromField.INTERNAL_PREFIXand the existingDATABASE_CONFIG_PREFIX/DRIVER_CONFIG_PREFIX.RelationalDatabaseConnectorConfig(debezium-connector-common): ChangedSNAPSHOT_FULL_COLUMN_SCAN_FORCEfield fromField.createInternal("snapshot.scan.all.columns.force")toField.createInternal("database.snapshot.scan.all.columns.force"), giving it the full nameinternal.database.snapshot.scan.all.columns.force. UpdatedJdbcConfigurationconstruction to also mergeconfig.subset(INTERNAL_DATABASE_CONFIG_PREFIX, true)andconfig.subset(INTERNAL_DRIVER_CONFIG_PREFIX, true).JdbcConnection(debezium-connector-common): Changed theSNAPSHOT_FULL_COLUMN_SCAN_FORCElookup inreadSchema()from using theFieldreference (whose name includes theinternal.database.prefix) to a string constant"snapshot.scan.all.columns.force", matching the post-subset key name inJdbcConfiguration.BinlogConnectionConfiguration(debezium-connector-binlog): Addedinternal.database.*andinternal.driver.*subset merges to theJdbcConfigurationconstruction.QueryInformationSchemaMetadata(debezium-connector-postgres): Added the same internal subset merges.ConfigurationTest(debezium-connector-common): AddedtestConfigurationMergeWithInternalPrefixestest verifying that properties withinternal.database.*andinternal.driver.*prefixes are correctly included in the merged configuration with prefixes stripped.Update 1 — 2026-05-13
Added
.withDeprecatedAliases("internal.snapshot.scan.all.columns.force")to theSNAPSHOT_FULL_COLUMN_SCAN_FORCEfield definition inRelationalDatabaseConnectorConfig.java, as requested by the reviewer. The alias uses the full old field name including theinternal.prefix, sinceField.withDeprecatedAliases()stores aliases as literal strings without auto-prefixing.Changes
PR Checklist
main🤖 Automated PR generated by the Naros AI Agent workflow.