Skip to content

DBZ-1423 The internal option snapshot.scan.all.columns.force should be defined with database prefix [DBZ-9619]#16

Open
naros-ai-agent[bot] wants to merge 2 commits into
mainfrom
dbz#1423-2
Open

DBZ-1423 The internal option snapshot.scan.all.columns.force should be defined with database prefix [DBZ-9619]#16
naros-ai-agent[bot] wants to merge 2 commits into
mainfrom
dbz#1423-2

Conversation

@naros-ai-agent

@naros-ai-agent naros-ai-agent Bot commented May 13, 2026

Copy link
Copy Markdown

Addresses issue DBZ-1423

Description

Adds internal.database. and internal.driver. prefix support to JdbcConfiguration construction so that internal properties like SNAPSHOT_FULL_COLUMN_SCAN_FORCE can be defined with a database. namespace prefix, making their relationship to the JDBC configuration self-documenting.

  • ConfigurationNames (debezium-config): Added INTERNAL_DATABASE_CONFIG_PREFIX ("internal.database.") and INTERNAL_DRIVER_CONFIG_PREFIX ("internal.driver.") constants, composed from Field.INTERNAL_PREFIX and the existing DATABASE_CONFIG_PREFIX/DRIVER_CONFIG_PREFIX.
  • RelationalDatabaseConnectorConfig (debezium-connector-common): Changed SNAPSHOT_FULL_COLUMN_SCAN_FORCE field from Field.createInternal("snapshot.scan.all.columns.force") to Field.createInternal("database.snapshot.scan.all.columns.force"), giving it the full name internal.database.snapshot.scan.all.columns.force. Updated JdbcConfiguration construction to also merge config.subset(INTERNAL_DATABASE_CONFIG_PREFIX, true) and config.subset(INTERNAL_DRIVER_CONFIG_PREFIX, true).
  • JdbcConnection (debezium-connector-common): Changed the SNAPSHOT_FULL_COLUMN_SCAN_FORCE lookup in readSchema() from using the Field reference (whose name includes the internal.database. prefix) to a string constant "snapshot.scan.all.columns.force", matching the post-subset key name in JdbcConfiguration.
  • BinlogConnectionConfiguration (debezium-connector-binlog): Added internal.database.* and internal.driver.* subset merges to the JdbcConfiguration construction.
  • QueryInformationSchemaMetadata (debezium-connector-postgres): Added the same internal subset merges.
  • ConfigurationTest (debezium-connector-common): Added testConfigurationMergeWithInternalPrefixes test verifying that properties with internal.database.* and internal.driver.* prefixes are correctly included in the merged configuration with prefixes stripped.

Update 1 — 2026-05-13

Added .withDeprecatedAliases("internal.snapshot.scan.all.columns.force") to the SNAPSHOT_FULL_COLUMN_SCAN_FORCE field definition in RelationalDatabaseConnectorConfig.java, as requested by the reviewer. The alias uses the full old field name including the internal. prefix, since Field.withDeprecatedAliases() stores aliases as literal strings without auto-prefixing.

Changes

Files changed (vs main):

 .../io/debezium/config/ConfigurationNames.java     |  2 ++
 .../binlog/jdbc/BinlogConnectionConfiguration.java |  6 +++++-
 .../main/java/io/debezium/jdbc/JdbcConnection.java |  3 ++-
 .../RelationalDatabaseConnectorConfig.java         |  8 ++++++--
 .../java/io/debezium/config/ConfigurationTest.java | 23 ++++++++++++++++++++++
 .../QueryInformationSchemaMetadata.java            |  4 +++-
 6 files changed, 41 insertions(+), 5 deletions(-)

Commits:

d5e944742e debezium/dbz#1423 Add deprecated alias to SNAPSHOT_FULL_COLUMN_SCAN_FORCE
2b8c245711 debezium/dbz#1423 Add internal.database/driver prefix support to JdbcConfiguration subset merging

PR Checklist

  • I have read the contribution guidelines and the governance document on PR expectations.
  • Minimal changes to code not directly related to your change (e.g. no unnecessary formatting changes or refactoring to existing code)
  • One feature/change per PR unless tightly coupled
  • Do a rebase on upstream main

🤖 Automated PR generated by the Naros AI Agent workflow.

…Configuration subset merging

Generated by AI agent in response to debezium/dbz#1423.

Signed-off-by: Chris Cranford <chris@hibernate.org>
…ORCE

Added `.withDeprecatedAliases("internal.snapshot.scan.all.columns.force")` to the `SNAPSHOT_FULL_COLUMN_SCAN_FORCE` field definition in `RelationalDatabaseConnectorConfig.java`, as requested by the reviewer. The alias uses the full old field name including the `internal.` prefix, since `Field.withDeprecatedAliases()` stores aliases as literal strings without auto-prefixing.

Generated by AI agent in response to debezium/dbz#1423.

Signed-off-by: Chris Cranford <chris@hibernate.org>
@naros-ai-agent

Copy link
Copy Markdown
Author

🤖 Agent re-ran in response to review feedback. New commit(s) pushed to dbz#1423-2; PR body updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant