Update urls for NLR pages and github repositories#658
Open
genevievestarke wants to merge 3 commits intoNatLabRockies:developfrom
Open
Update urls for NLR pages and github repositories#658genevievestarke wants to merge 3 commits intoNatLabRockies:developfrom
genevievestarke wants to merge 3 commits intoNatLabRockies:developfrom
Conversation
johnjasa
approved these changes
Apr 8, 2026
Collaborator
johnjasa
left a comment
There was a problem hiding this comment.
Thanks for this PR, @genevievestarke! I love your proactive approach and you being discerning in what all to change and what to keep here (not just blindly find-and-replacing).
I've pushed up some minor additions that I think we should tackle in this one. Namely GitHub repos that have been renamed (NREL -> NatLabRockies and WISDEM -> NLRWindSystems) that GitHub would probably always redirect (until it doesn't), but we might as well update them.
This is ready to come in imo, but I'll just approve and won't merge in case you had other changes coming in or other folks have comments. Feel free to merge it when you want!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update NLR page links, NLR references and GitHub links
Many of the links in the docs and references would stop working at the end of May. I've updated a lot of the NLR page links, references to NLR, and GitHub repository links. Things that I did not update
test_nrel_solar_resource_file_downloadsSection 1: Type of Contribution
Section 2: Draft PR Checklist
TODO:
Type of Reviewer Feedback Requested (on Draft PR)
Structural feedback:
Implementation feedback:
Other feedback:
Section 3: General PR Checklist
docs/files are up-to-date, or added when necessaryCHANGELOG.md"A complete thought. [PR XYZ]((https://github.com/NatLabRockies/H2Integrate/pull/XYZ)", where
XYZshould be replaced with the actual number.Section 3: Related Issues
Section 4: Impacted Areas of the Software
Section 4.1: New Files
path/to/file.extensionmethod1: What and why something was changed in one sentence or less.Section 4.2: Modified Files
path/to/file.extensionmethod1: What and why something was changed in one sentence or less.Section 5: Additional Supporting Information
Section 6: Test Results, if applicable
Section 7 (Optional): New Model Checklist
docs/developer_guide/coding_guidelines.mdattrsclass to define theConfigto load in attributes for the modelBaseConfigorCostModelBaseConfiginitialize()method,setup()method,compute()methodCostModelBaseClasssupported_models.pycreate_financial_modelinh2integrate_model.pytest_all_examples.pydocs/user_guide/model_overview.mddocs/section<model_name>.mdis added to the_toc.yml