Remove remaining HOPP integration and references - #827
Open
johnjasa wants to merge 14 commits into
Open
Conversation
johnjasa
changed the title
kbrunik
reviewed
Aug 12, 2026
|
|
||
| In some cases, the performance and cost models are tightly coupled, and it might make sense to combine them into a single model. | ||
| This is currently the case for the `HOPP` and `h2_storage` wrappers, where the performance and cost models are combined into a single component. | ||
| This is currently the case for the `h2_storage`, `WOMBATElectrolyzerModel`, and `ArdWindPlantModel` |
Collaborator
There was a problem hiding this comment.
I realized that this is slightly out of date since you can't call a model h2_storage anymore so maybe that should also be removed
Collaborator
Author
There was a problem hiding this comment.
Good call, removed and changed H2IntegrateModel as well
johnjasa
marked this pull request as ready for review
August 12, 2026 16:58
johnjasa
marked this pull request as draft
August 12, 2026 18:08
johnjasa
marked this pull request as ready for review
August 12, 2026 18:08
johnjasa
marked this pull request as draft
August 12, 2026 18:53
johnjasa
marked this pull request as ready for review
August 12, 2026 18:53
kbrunik
reviewed
Aug 14, 2026
| ```python | ||
| combined_performance_and_cost_model_technologies = ['HOPPComponent', 'h2_storage', '<your_tech_here>'] | ||
| combined_performance_and_cost_model_technologies = [ | ||
| 'h2_storage', |
kbrunik
reviewed
Aug 14, 2026
|
|
||
| When you push to your fork, or open a PR, your tests will be run against the | ||
| [Continuous Integration (CI)](https://github.com/NatLabRockies/HOPP/actions) suite. This will start a build | ||
| [Continuous Integration (CI)](https://github.com/NatLabRockies/H2Integrate/actions) suite. This will start a build |
kbrunik
approved these changes
Aug 14, 2026
| """ | ||
| # TODO: provide more control; currently don't use `start_time` | ||
| # see HOPP implementation | ||
| # see earlier dispatch implementation details |
Collaborator
There was a problem hiding this comment.
I think you could just remove this comment
|
|
||
| NOTE: that this method was brought over from HOPP. The link to the original method is here: | ||
| https://github.com/NatLabRockies/HOPP/blob/dde63faf6ea804828b2a7054cd6ec2c0a2f19614/hopp/simulation/technologies/dispatch/dispatch_problem_state.py | ||
| NOTE: this method originated from an earlier dispatch implementation and |
Collaborator
There was a problem hiding this comment.
Do we not want to say this came from HOPP?
| def format_resource_data(self, hub_height, wind_resource_data): | ||
| # NOTE: could weight resource data of bounding heights like | ||
| # `weighted_parse_resource_data` method in HOPP | ||
| # `weighted_parse_resource_data` used in earlier wind workflows |
Collaborator
There was a problem hiding this comment.
I think we could leave this saying HOPP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove remaining HOPP integration and references
This PR removes remaining HOPP integration from H2Integrate and migrates the last active HOPP-backed example path to native H2I components.
Summary of changes:
hoppdependency from the project dependency stack.Section 1: Type of Contribution
Section 2: Draft PR Checklist
TODO:
Type of Reviewer Feedback Requested (on Draft PR)
Structural feedback:
Confirm that removing the HOPP converter package does not conflict with any planned near-term work.
Section 3: General PR Checklist
docs/files are up-to-date, or added when necessaryCHANGELOG.md"A complete thought. [PR XYZ]((https://github.com/NatLabRockies/H2Integrate/pull/XYZ)", where
XYZshould be replaced with the actual number.Section 4: Related Issues
Fully addresses #824
Section 5: Impacted Areas of the Software
Section 5.1: New Files
N/A
Section 5.2: Modified Files
pyproject.tomlhopp>=3.3.0from dependencies.h2integrate/core/supported_models.pyh2integrate/core/h2integrate_model.pyexamples/25_sizing_modes/tech_config.yamlexamples/25_sizing_modes/plant_config.yamlexamples/25_sizing_modes/run_size_modes.pyh2integrate/converters/hydrogen/test/test_size_modes.pyh2integrate/core/test/test_utilities.pyh2integrate/tools/test/test_profast_tools.pyh2integrate/converters/wind/test/conftest.pyh2integrate/resource/utilities/test/conftest.pydocs/intro.mddocs/getting_started/expected_user_knowledge.mddocs/developer_guide/adding_a_new_technology.mddocs/user_guide/model_overview.mdDeleted files:
h2integrate/converters/hopp/hopp_mgmt.pyh2integrate/converters/hopp/hopp_wrapper.pyh2integrate/converters/hopp/__init__.pyh2integrate/converters/hopp/test/test_hopp_caching.pyh2integrate/converters/hopp/test/conftest.pyh2integrate/tools/h2integrate_sim_file_utils.pyexamples/25_sizing_modes/tech_inputs/hopp_config_tx.yamlSection 6: Additional Supporting Information
This PR is intentionally broad and removes remaining references in active source and documentation to keep the repository aligned with native H2I modeling patterns.
Section 7: Test Results, if applicable
Section 8 (Optional): New Model Checklist
N/A