Skip to content

Jf/set initial param levels - #98

Merged
juflorez merged 31 commits into
mainfrom
jf/set_initial_param_levels
Jul 15, 2026
Merged

Jf/set initial param levels#98
juflorez merged 31 commits into
mainfrom
jf/set_initial_param_levels

Conversation

@juflorez

Copy link
Copy Markdown
Collaborator

Creating initial PR now-will update with graphics/analysis on impact in varying param. Core functionality with backwards compat file reading tests is present though

@codecov-commenter

codecov-commenter commented Nov 24, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.67925% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.14%. Comparing base (c793303) to head (4ffb98a).

Files with missing lines Patch % Lines
PRASCore.jl/src/Systems/assets.jl 64.70% 6 Missing ⚠️
PRASFiles.jl/src/Systems/read.jl 92.40% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   83.16%   84.14%   +0.98%     
==========================================
  Files          45       45              
  Lines        2429     2491      +62     
==========================================
+ Hits         2020     2096      +76     
+ Misses        409      395      -14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 12 changed files in this pull request and generated 23 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread PRASCore.jl/src/Systems/assets.jl Outdated
Comment thread PRASCore.jl/src/Systems/assets.jl Outdated
Comment thread docs/src/SystemModel_HDF5_spec.md Outdated
Comment thread docs/src/SystemModel_HDF5_spec.md Outdated
Comment thread PRASCore.jl/src/Systems/assets.jl Outdated
Comment thread docs/src/SystemModel_HDF5_spec.md Outdated
Comment thread PRASFiles.jl/src/Systems/read.jl Outdated
Comment thread PRASFiles.jl/test/runtests.jl Outdated
Comment thread PRASCore.jl/src/Systems/assets.jl Outdated
Comment thread PRASCore.jl/src/Simulations/Simulations.jl Outdated
@juflorez
juflorez requested a review from Copilot November 25, 2025 22:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 12 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread PRASFiles.jl/test/runtests.jl Outdated
Comment thread docs/src/SystemModel_HDF5_spec.md Outdated
Comment thread PRASCore.jl/src/Systems/assets.jl Outdated
Comment thread PRASFiles.jl/src/Systems/read.jl Outdated
Comment thread PRASFiles.jl/src/Systems/read.jl Outdated
Comment thread docs/src/SystemModel_HDF5_spec.md Outdated
Comment thread docs/src/SystemModel_HDF5_spec.md Outdated
Comment thread PRASCore.jl/src/Simulations/Simulations.jl Outdated
Comment thread PRASCore.jl/src/Systems/assets.jl Outdated
Comment thread PRASCore.jl/src/Systems/assets.jl Outdated
Comment thread PRASFiles.jl/src/Systems/read.jl Outdated
Comment thread PRASFiles.jl/test/runtests.jl Outdated
Comment thread PRASFiles.jl/test/runtests.jl Outdated
Comment thread PRASFiles.jl/src/Systems/read.jl Outdated
Comment thread PRASFiles.jl/src/Systems/read.jl Outdated
Comment thread PRASFiles.jl/src/Systems/read.jl Outdated
@sriharisundar
sriharisundar self-requested a review July 13, 2026 21:11
@juflorez
juflorez force-pushed the jf/set_initial_param_levels branch from 88e0839 to b69eb35 Compare July 13, 2026 21:59
@sriharisundar

Copy link
Copy Markdown
Member

LGTM, thanks! Please squash and merge after all tests pass.

@juflorez
juflorez merged commit 67064f5 into main Jul 15, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants