Open
Conversation
When logging into the admin, if the api_users table was very large, performance could be poor for the admins on the initial login. It was due to this fetch of an API key based on the e-mail address that wasn't indexed: https://github.com/NatLabRockies/api-umbrella/blob/bdda3929441a24e4aaa6fe114d8770985e0e76d5/src/api-umbrella/web-app/actions/admin/sessions.lua#L201 This adds an index to improve that query performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When logging into the admin, if the api_users table was very large, performance could be poor for the admins on the initial login. It was due to this fetch of an API key based on the e-mail address that wasn't indexed:
api-umbrella/src/api-umbrella/web-app/actions/admin/sessions.lua
Line 201 in bdda392
This adds an index to improve that query performance.
Fixes 18F/api.data.gov#701