Start-Stop fixes/cleanup#271
Open
kylecarow wants to merge 13 commits into
Open
Conversation
…on-RES vehicles, we need better test coverage for thermal soak
…eh_dynamics to DfcoControls instead of standalone fn, engine_on -> fc_on rename
Collaborator
Author
|
@robinsteuteville Assigned you to review this PR - no rush but I would like this to be included before our next release :) |
kylecarow
force-pushed
the
f3/stop-start-pyfunctions
branch
from
July 17, 2026 23:14
bd5a79a to
ed8bfca
Compare
kylecarow
force-pushed
the
f3/stop-start-pyfunctions
branch
from
July 18, 2026 16:36
426c020 to
ed8bfca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://github.nrel.gov/MBAP/fastsim/issues/425
This PR:
common.rsstandalone functions into a traitStartStopControl, impl for Conv and HEV start stop controlspubstruct to organize parameters, makes namespace messyengine_ontofc_onthroughoutOther notes
mark_non_thermal_freshand elsewhere