Skip to content

Enable Cross Platform (Issue #30)#31

Open
RhysTabor-dev wants to merge 11 commits intoNatVanG:mainfrom
RhysTabor-dev:issue/30_enable_cross_platform
Open

Enable Cross Platform (Issue #30)#31
RhysTabor-dev wants to merge 11 commits intoNatVanG:mainfrom
RhysTabor-dev:issue/30_enable_cross_platform

Conversation

@RhysTabor-dev
Copy link
Copy Markdown

Changes

The intention of this change is in relation to Issue #30 to enable Cross-Platform output of all formats, including HTML and Images.

@NatVanG
Copy link
Copy Markdown
Owner

NatVanG commented Apr 18, 2024

Many thanks Rhys, I will review asap :) This had been on my to-do list and I'm really grateful for your contribution.

@NatVanG
Copy link
Copy Markdown
Owner

NatVanG commented Apr 24, 2024

Thanks again Rhys, identified some issues i.e. 1) unit test fails due to win library rename, 2) font size in Skia wireframe pages is smaller than original, 3) as yet unidentified cause of error when rendering wireframes for a local report.json file. Shall I commit fixes to your branch first?

@RhysTabor-dev
Copy link
Copy Markdown
Author

Thanks again Rhys, identified some issues i.e. 1) unit test fails due to win library rename, 2) font size in Skia wireframe pages is smaller than original, 3) as yet unidentified cause of error when rendering wireframes for a local report.json file. Shall I commit fixes to your branch first?

Hey, ah great - thanks for spotting. Feel free to check in any already made fixes to the branch, I'll take a look into the local report.json failure as soon as I get a chance.

@NatVanG
Copy link
Copy Markdown
Owner

NatVanG commented Jul 7, 2025

Hi @RhysTabor-dev , FYI for now I've ported your code to PBI Inspector V2 as this is where most of my spare time is invested currently, see https://github.com/NatVanG/PBI-InspectorV2/tree/remove-win-dependencies (merge into the main branch is pending but shouldn't be long). I've used dependency injection to run the cross-platform solution with the CLI while retaining the windows-specific drawing library for the Windows Form (as there are some rendering differences and I suspect the wireframe output is mostly used with the Windows Form app rather than the CLI). Thank you very much for your contribution.

@RhysTabor-dev
Copy link
Copy Markdown
Author

Hey @NatVanG thanks for sorting this across.

I'll pull it all down this side and take another look, it's been a while since I had a chance to sit down with this change.

Appreciate your patience on this, and love the effort of extending to all fabric items. Lots of exciting developments from yourself and Microsoft on the analytics space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants