Skip to content

feat(defaults): every device on the Devices page ships OFF -- pure opt-in #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanNeurotic merged 2 commits into from
Jul 20, 2026
Merged

feat(defaults): every device on the Devices page ships OFF -- pure opt-in #238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f3dbb0
feat(defaults): every device on the Devices page ships OFF -- pure op…
NathanNeurotic Jul 20, 2026
61036e7
style(opl): align the gEnableUSB comment per CI clang-format 12 (appl…
NathanNeurotic Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/opl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2879,12 +2879,16 @@ static void setDefaults(void)
gXSensitivity = 1;
gYSensitivity = 1;

gBDMStartMode = START_MODE_MANUAL;
gHDDStartMode = START_MODE_DISABLED; // RiptOPL: APA/PFS HDD OFF by default (was Manual); user opts in
gETHStartMode = START_MODE_DISABLED; // RiptOPL: network/SMB OFF by default (was Manual); user opts in
gAPPStartMode = START_MODE_MANUAL;
gMMCEStartMode = START_MODE_MANUAL;
gFAVStartMode = START_MODE_MANUAL;
// RiptOPL doctrine (NathanNeurotic, 2026-07-20): EVERY device on the Devices page ships OFF -- the
// user opts in to exactly what their rig has. A fresh install boots to the start menu with no tabs
// (deferredInit's boot select handles the nothing-registered case explicitly) and the user enables
// devices in Settings. Existing saved configs override all of these on load.
gBDMStartMode = START_MODE_DISABLED;
gHDDStartMode = START_MODE_DISABLED;
gETHStartMode = START_MODE_DISABLED;
gAPPStartMode = START_MODE_DISABLED;
gMMCEStartMode = START_MODE_DISABLED;
gFAVStartMode = START_MODE_DISABLED;

gMMCESlot = 2; //Default to first Auto slot
gMMCEIGRSlot = 3;
Expand All @@ -2899,7 +2903,7 @@ static void setDefaults(void)
gMMCEAckWaitCycles = 5;
gMMCEUseAlarms = 1;

gEnableUSB = 1;
gEnableUSB = 0; // all block-device toggles OFF by default too (same opt-in doctrine)
gEnableILK = 0;
gEnableMX4SIO = 0;
gEnableBdmHDD = 0; // exFAT BDM HDD OFF by default (the other "HDD type"; APA/PFS is gHDDStartMode above)
Expand Down